Re: [FFmpeg-devel] [PATCH 04/20] avformat/matroskaenc: Reuse random seed

2020-04-19 Thread Andreas Rheinhardt
Steve Lhomme: >> On April 19, 2020 9:11 AM Andreas Rheinhardt >> wrote: >> >> >> Steve Lhomme: >>> Wouldn't it be better to set the AVLFG in the MatroskaMuxContext in >>> mkv_init and keep using it when needed ? >>> >>> Then you can still update UIDs in the location you really need to create

Re: [FFmpeg-devel] [PATCH 04/20] avformat/matroskaenc: Reuse random seed

2020-04-19 Thread Steve Lhomme
> On April 19, 2020 9:11 AM Andreas Rheinhardt > wrote: > > > Steve Lhomme: > > Wouldn't it be better to set the AVLFG in the MatroskaMuxContext in > > mkv_init and keep using it when needed ? > > > > Then you can still update UIDs in the location you really need to create > > them. > > >

Re: [FFmpeg-devel] [PATCH 04/20] avformat/matroskaenc: Reuse random seed

2020-04-19 Thread Andreas Rheinhardt
Steve Lhomme: > Wouldn't it be better to set the AVLFG in the MatroskaMuxContext in mkv_init > and keep using it when needed ? > > Then you can still update UIDs in the location you really need to create them. > What other UIDs do I need? UIDs for tracks and attachments are created in init as is

Re: [FFmpeg-devel] [PATCH 04/20] avformat/matroskaenc: Reuse random seed

2020-04-19 Thread Steve Lhomme
Wouldn't it be better to set the AVLFG in the MatroskaMuxContext in mkv_init and keep using it when needed ? Then you can still update UIDs in the location you really need to create them. > On April 5, 2020 5:59 PM Andreas Rheinhardt > wrote: > > > This commit reuses the random seed generat