Re: [FFmpeg-devel] [PATCH 0/5] adding ICC profile support to MOV decode/encode

2020-03-09 Thread Derek Buitenhuis
On 09/03/2020 21:43, James Almer wrote: > The second patch is very outdated, and should be squashed with the first > (alongside a lavc minor version bump that would be reflected in the > APIChanges entry). Yes, the update and bump before pushing is implied, I thought. - Derek

Re: [FFmpeg-devel] [PATCH 0/5] adding ICC profile support to MOV decode/encode

2020-03-09 Thread James Almer
On 3/9/2020 5:09 PM, Derek Buitenhuis wrote: > On 07/10/2019 11:40, vectronic wrote: >> Hello, >> >> Wondering if anyone would be able to review these changes? I’m currently >> using this in production and it is working well. > > The patch set looks OK to me. I will push in 24h if nobody objects.

Re: [FFmpeg-devel] [PATCH 0/5] adding ICC profile support to MOV decode/encode

2020-03-09 Thread Derek Buitenhuis
On 07/10/2019 11:40, vectronic wrote: > Hello, > > Wondering if anyone would be able to review these changes? I’m currently > using this in production and it is working well. The patch set looks OK to me. I will push in 24h if nobody objects. - Derek

Re: [FFmpeg-devel] [PATCH 0/5] adding ICC profile support to MOV decode/encode

2019-10-07 Thread vectronic
> On 23 Sep 2019, at 21:43, vectronic wrote: > > As discussed earlier on this mailing list, I needed to implement support for > reading and writing ICC profiles which can be stored in MOV/MP4 sample > descriptor colour information. > > The overall changes are: > > 1. Add a new enum value AVPa