Re: [FFmpeg-devel] [PATCH]lavu/threadmessage: Properly declare a function pointer

2020-05-02 Thread Nicolas George
Carl Eugen Hoyos (12020-05-02): > My guess is to avoid a race condition. Avoid a race condition is: take local variable, unlock, use local variable. Here it is take local variable, lock, use local variable. Regards, -- Nicolas George signature.asc Description: PGP signature

Re: [FFmpeg-devel] [PATCH]lavu/threadmessage: Properly declare a function pointer

2020-05-02 Thread Carl Eugen Hoyos
Am Sa., 2. Mai 2020 um 11:56 Uhr schrieb Nicolas George : > > Carl Eugen Hoyos (12020-05-02): > > Could you tell me where free_func() is used as a void *? > > I don't see it. > > You are right, I misread. The problem is even simpler: why is there an > intermediate variable in the first place? My g

Re: [FFmpeg-devel] [PATCH]lavu/threadmessage: Properly declare a function pointer

2020-05-02 Thread Nicolas George
Carl Eugen Hoyos (12020-05-02): > Could you tell me where free_func() is used as a void *? > I don't see it. You are right, I misread. The problem is even simpler: why is there an intermediate variable in the first place? Just test mq->free_func directly. Regards, -- Nicolas George signatur

Re: [FFmpeg-devel] [PATCH]lavu/threadmessage: Properly declare a function pointer

2020-05-02 Thread Carl Eugen Hoyos
Am Sa., 2. Mai 2020 um 11:06 Uhr schrieb Nicolas George : > > Carl Eugen Hoyos (12020-05-01): > > Hi! > > > > Attached patch, inspired by a patch by Andreas, fixes the following > > warning when -Wpedantic is used: > > CC libavutil/threadmessage.o > > libavutil/threadmessage.c: In function ‘av

Re: [FFmpeg-devel] [PATCH]lavu/threadmessage: Properly declare a function pointer

2020-05-02 Thread Nicolas George
Carl Eugen Hoyos (12020-05-01): > Hi! > > Attached patch, inspired by a patch by Andreas, fixes the following > warning when -Wpedantic is used: > CC libavutil/threadmessage.o > libavutil/threadmessage.c: In function ‘av_thread_message_flush’: > libavutil/threadmessage.c:222:23: warning: ISO