Re: [FFmpeg-devel] [PATCH]lavf/rtmpcrypt: Add a cast to silence a warning

2018-04-26 Thread Carl Eugen Hoyos
2018-04-26 13:34 GMT+02:00, Reino Wijnsma : > On 22-4-2018 0:52, Reino Wijnsma wrote: >> On 16-4-2018 0:19, Carl Eugen Hoyos wrote: >>> rtmpe_write() exploits knowledge about av_rc4_crypt() internals and >>> passes the same >>> pointer as src and dst. I assume this is intentional for performance

Re: [FFmpeg-devel] [PATCH]lavf/rtmpcrypt: Add a cast to silence a warning

2018-04-26 Thread Reino Wijnsma
On 22-4-2018 0:52, Reino Wijnsma wrote: > On 16-4-2018 0:19, Carl Eugen Hoyos wrote: >> rtmpe_write() exploits knowledge about av_rc4_crypt() internals and >> passes the same >> pointer as src and dst. I assume this is intentional for performance >> reasons, the only >> way to silence the resulti

Re: [FFmpeg-devel] [PATCH]lavf/rtmpcrypt: Add a cast to silence a warning

2018-04-21 Thread Reino Wijnsma
On 16-4-2018 0:19, Carl Eugen Hoyos wrote: > rtmpe_write() exploits knowledge about av_rc4_crypt() internals and > passes the same > pointer as src and dst. I assume this is intentional for performance > reasons, the only > way to silence the resulting warning is a cast afaict. > > Please comment,

Re: [FFmpeg-devel] [PATCH]lavf/rtmpcrypt: Add a cast to silence a warning

2018-04-18 Thread Carl Eugen Hoyos
2018-04-16 0:19 GMT+02:00, Carl Eugen Hoyos : > Hi! > > rtmpe_write() exploits knowledge about av_rc4_crypt() internals and > passes the same > pointer as src and dst. I assume this is intentional for performance > reasons, the only > way to silence the resulting warning is a cast afaict. I will p