Re: [FFmpeg-devel] [PATCH]lavf/latmenc: Error out for invalid codecs

2019-03-20 Thread Carl Eugen Hoyos
2017-11-01 3:39 GMT+01:00, Michael Niedermayer : > On Wed, Nov 01, 2017 at 02:17:06AM +0100, Carl Eugen Hoyos wrote: >> 2017-10-31 17:38 GMT+01:00 Michael Niedermayer : >> > On Mon, Oct 30, 2017 at 11:51:30PM +0100, Carl Eugen Hoyos wrote: >> >> Hi! >> >> >> >> Attached patch makes sure the loas mu

Re: [FFmpeg-devel] [PATCH]lavf/latmenc: Error out for invalid codecs

2017-11-01 Thread Nicolas George
Le primidi 11 brumaire, an CCXXVI, James Almer a écrit : > I guess he's saying If you have to guess, then he is not saying it, he is hinting at it with half sentences containing only the draft of an argument. I wish he would start making full sentences with full arguments. Regards, -- Nicolas

Re: [FFmpeg-devel] [PATCH]lavf/latmenc: Error out for invalid codecs

2017-11-01 Thread Carl Eugen Hoyos
2017-11-01 16:59 GMT+01:00 Paul B Mahol : > On 11/1/17, Carl Eugen Hoyos wrote: >> 2017-11-01 15:42 GMT+01:00 Paul B Mahol : >>> On 11/1/17, Carl Eugen Hoyos wrote: >> >>> Not creating broken webp files, see difference. >> >> How do you know that als-in-loas in invalid? > > Because you do not cla

Re: [FFmpeg-devel] [PATCH]lavf/latmenc: Error out for invalid codecs

2017-11-01 Thread Paul B Mahol
On 11/1/17, Carl Eugen Hoyos wrote: > 2017-11-01 15:42 GMT+01:00 Paul B Mahol : >> On 11/1/17, Carl Eugen Hoyos wrote: > >> Not creating broken webp files, see difference. > > How do you know that als-in-loas in invalid? Because you do not claim it is valid. > >>> Iirc, the practice used to be

Re: [FFmpeg-devel] [PATCH]lavf/latmenc: Error out for invalid codecs

2017-11-01 Thread Carl Eugen Hoyos
2017-11-01 15:42 GMT+01:00 Paul B Mahol : > On 11/1/17, Carl Eugen Hoyos wrote: > Not creating broken webp files, see difference. How do you know that als-in-loas in invalid? >> Iirc, the practice used to be to first implement encoders / muxers, >> then decoders / demuxers... > > No, it is othe

Re: [FFmpeg-devel] [PATCH]lavf/latmenc: Error out for invalid codecs

2017-11-01 Thread Paul B Mahol
On 11/1/17, Carl Eugen Hoyos wrote: > 2017-11-01 15:26 GMT+01:00 James Almer : >> On 11/1/2017 11:23 AM, Carl Eugen Hoyos wrote: >>> 2017-11-01 14:39 GMT+01:00 Paul B Mahol : On 11/1/17, Carl Eugen Hoyos wrote: > 2017-11-01 13:32 GMT+01:00 Paul B Mahol : >> On 11/1/17, Hendrik Leppke

Re: [FFmpeg-devel] [PATCH]lavf/latmenc: Error out for invalid codecs

2017-11-01 Thread James Almer
On 11/1/2017 11:33 AM, Carl Eugen Hoyos wrote: > 2017-11-01 15:26 GMT+01:00 James Almer : >> On 11/1/2017 11:23 AM, Carl Eugen Hoyos wrote: >>> 2017-11-01 14:39 GMT+01:00 Paul B Mahol : On 11/1/17, Carl Eugen Hoyos wrote: > 2017-11-01 13:32 GMT+01:00 Paul B Mahol : >> On 11/1/17, Hend

Re: [FFmpeg-devel] [PATCH]lavf/latmenc: Error out for invalid codecs

2017-11-01 Thread Carl Eugen Hoyos
2017-11-01 15:26 GMT+01:00 James Almer : > On 11/1/2017 11:23 AM, Carl Eugen Hoyos wrote: >> 2017-11-01 14:39 GMT+01:00 Paul B Mahol : >>> On 11/1/17, Carl Eugen Hoyos wrote: 2017-11-01 13:32 GMT+01:00 Paul B Mahol : > On 11/1/17, Hendrik Leppkes wrote: >> On Wed, Nov 1, 2017 at 11:0

Re: [FFmpeg-devel] [PATCH]lavf/latmenc: Error out for invalid codecs

2017-11-01 Thread James Almer
On 11/1/2017 11:23 AM, Carl Eugen Hoyos wrote: > 2017-11-01 14:39 GMT+01:00 Paul B Mahol : >> On 11/1/17, Carl Eugen Hoyos wrote: >>> 2017-11-01 13:32 GMT+01:00 Paul B Mahol : On 11/1/17, Hendrik Leppkes wrote: > On Wed, Nov 1, 2017 at 11:09 AM, Paul B Mahol wrote: >> On 11/1/17, He

Re: [FFmpeg-devel] [PATCH]lavf/latmenc: Error out for invalid codecs

2017-11-01 Thread Carl Eugen Hoyos
2017-11-01 14:39 GMT+01:00 Paul B Mahol : > On 11/1/17, Carl Eugen Hoyos wrote: >> 2017-11-01 13:32 GMT+01:00 Paul B Mahol : >>> On 11/1/17, Hendrik Leppkes wrote: On Wed, Nov 1, 2017 at 11:09 AM, Paul B Mahol wrote: > On 11/1/17, Hendrik Leppkes wrote: >> On Wed, Nov 1, 2017 at 10

Re: [FFmpeg-devel] [PATCH]lavf/latmenc: Error out for invalid codecs

2017-11-01 Thread Paul B Mahol
On 11/1/17, Carl Eugen Hoyos wrote: > 2017-11-01 13:32 GMT+01:00 Paul B Mahol : >> On 11/1/17, Hendrik Leppkes wrote: >>> On Wed, Nov 1, 2017 at 11:09 AM, Paul B Mahol wrote: On 11/1/17, Hendrik Leppkes wrote: > On Wed, Nov 1, 2017 at 10:44 AM, Paul B Mahol wrote: >> On 10/31/17,

Re: [FFmpeg-devel] [PATCH]lavf/latmenc: Error out for invalid codecs

2017-11-01 Thread Carl Eugen Hoyos
2017-11-01 13:32 GMT+01:00 Paul B Mahol : > On 11/1/17, Hendrik Leppkes wrote: >> On Wed, Nov 1, 2017 at 11:09 AM, Paul B Mahol wrote: >>> On 11/1/17, Hendrik Leppkes wrote: On Wed, Nov 1, 2017 at 10:44 AM, Paul B Mahol wrote: > On 10/31/17, Michael Niedermayer wrote: >> On Mon, O

Re: [FFmpeg-devel] [PATCH]lavf/latmenc: Error out for invalid codecs

2017-11-01 Thread Paul B Mahol
On 11/1/17, Hendrik Leppkes wrote: > On Wed, Nov 1, 2017 at 11:09 AM, Paul B Mahol wrote: >> On 11/1/17, Hendrik Leppkes wrote: >>> On Wed, Nov 1, 2017 at 10:44 AM, Paul B Mahol wrote: On 10/31/17, Michael Niedermayer wrote: > On Mon, Oct 30, 2017 at 11:51:30PM +0100, Carl Eugen Hoyos

Re: [FFmpeg-devel] [PATCH]lavf/latmenc: Error out for invalid codecs

2017-11-01 Thread Hendrik Leppkes
On Wed, Nov 1, 2017 at 11:09 AM, Paul B Mahol wrote: > On 11/1/17, Hendrik Leppkes wrote: >> On Wed, Nov 1, 2017 at 10:44 AM, Paul B Mahol wrote: >>> On 10/31/17, Michael Niedermayer wrote: On Mon, Oct 30, 2017 at 11:51:30PM +0100, Carl Eugen Hoyos wrote: > Hi! > > Attached pat

Re: [FFmpeg-devel] [PATCH]lavf/latmenc: Error out for invalid codecs

2017-11-01 Thread Paul B Mahol
On 11/1/17, Hendrik Leppkes wrote: > On Wed, Nov 1, 2017 at 10:44 AM, Paul B Mahol wrote: >> On 10/31/17, Michael Niedermayer wrote: >>> On Mon, Oct 30, 2017 at 11:51:30PM +0100, Carl Eugen Hoyos wrote: Hi! Attached patch makes sure the loas muxer does not try to write anythi

Re: [FFmpeg-devel] [PATCH]lavf/latmenc: Error out for invalid codecs

2017-11-01 Thread Hendrik Leppkes
On Wed, Nov 1, 2017 at 10:44 AM, Paul B Mahol wrote: > On 10/31/17, Michael Niedermayer wrote: >> On Mon, Oct 30, 2017 at 11:51:30PM +0100, Carl Eugen Hoyos wrote: >>> Hi! >>> >>> Attached patch makes sure the loas muxer does not try to write >>> anything but aac and latm. >>> >>> Please comment,

Re: [FFmpeg-devel] [PATCH]lavf/latmenc: Error out for invalid codecs

2017-11-01 Thread Paul B Mahol
On 10/31/17, Michael Niedermayer wrote: > On Mon, Oct 30, 2017 at 11:51:30PM +0100, Carl Eugen Hoyos wrote: >> Hi! >> >> Attached patch makes sure the loas muxer does not try to write >> anything but aac and latm. >> >> Please comment, Carl Eugen > >> latmenc.c |4 >> 1 file changed, 4 i

Re: [FFmpeg-devel] [PATCH]lavf/latmenc: Error out for invalid codecs

2017-10-31 Thread Michael Niedermayer
On Wed, Nov 01, 2017 at 02:17:06AM +0100, Carl Eugen Hoyos wrote: > 2017-10-31 17:38 GMT+01:00 Michael Niedermayer : > > On Mon, Oct 30, 2017 at 11:51:30PM +0100, Carl Eugen Hoyos wrote: > >> Hi! > >> > >> Attached patch makes sure the loas muxer does not try to write > >> anything but aac and latm

Re: [FFmpeg-devel] [PATCH]lavf/latmenc: Error out for invalid codecs

2017-10-31 Thread Carl Eugen Hoyos
2017-10-31 17:38 GMT+01:00 Michael Niedermayer : > On Mon, Oct 30, 2017 at 11:51:30PM +0100, Carl Eugen Hoyos wrote: >> Hi! >> >> Attached patch makes sure the loas muxer does not try to write >> anything but aac and latm. >> >> Please comment, Carl Eugen > >> latmenc.c |4 >> 1 file chan

Re: [FFmpeg-devel] [PATCH]lavf/latmenc: Error out for invalid codecs

2017-10-31 Thread Michael Niedermayer
On Mon, Oct 30, 2017 at 11:51:30PM +0100, Carl Eugen Hoyos wrote: > Hi! > > Attached patch makes sure the loas muxer does not try to write > anything but aac and latm. > > Please comment, Carl Eugen > latmenc.c |4 > 1 file changed, 4 insertions(+) > 2b64f3d5ecb189e77b85dbab7a6cbfe9657