Re: [FFmpeg-devel] [PATCH]configure: Add -Wno-main

2017-10-07 Thread Carl Eugen Hoyos
2017-10-07 16:04 GMT+02:00 James Almer : > On 10/7/2017 11:02 AM, Carl Eugen Hoyos wrote: >> One possibility attached. >> >> Please comment, Carl Eugen >> >> >> 0001-lavfi-Rename-local-variables-main-as-master.patch >> >> >> From 0876a93917c8fe06a3d9b748c39e4f643c2ecd02 Mon Sep 17 00:00:00 2001 >>

Re: [FFmpeg-devel] [PATCH]configure: Add -Wno-main

2017-10-07 Thread James Almer
On 10/7/2017 11:02 AM, Carl Eugen Hoyos wrote: > One possibility attached. > > Please comment, Carl Eugen > > > 0001-lavfi-Rename-local-variables-main-as-master.patch > > > From 0876a93917c8fe06a3d9b748c39e4f643c2ecd02 Mon Sep 17 00:00:00 2001 > From: Carl Eugen Hoyos > Date: Sat, 7 Oct 2017

Re: [FFmpeg-devel] [PATCH]configure: Add -Wno-main

2017-10-07 Thread Carl Eugen Hoyos
One possibility attached. Please comment, Carl Eugen From 0876a93917c8fe06a3d9b748c39e4f643c2ecd02 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Sat, 7 Oct 2017 15:59:22 +0200 Subject: [PATCH] lavfi: Rename local variables "main" as "master". Silences several warnings: main is usually a

Re: [FFmpeg-devel] [PATCH]configure: Add -Wno-main

2017-10-06 Thread James Almer
On 10/6/2017 10:45 PM, Carl Eugen Hoyos wrote: > 2017-09-18 3:37 GMT+02:00 Carl Eugen Hoyos : >> Hi! >> >> Attached patch fixes several warnings when compiling libavfilter with >> current gcc. > > Ping. > > Should the warnings just stay? > > Thank you, Carl Eugen I'll change the name of the var

Re: [FFmpeg-devel] [PATCH]configure: Add -Wno-main

2017-10-06 Thread Carl Eugen Hoyos
2017-09-18 3:37 GMT+02:00 Carl Eugen Hoyos : > Hi! > > Attached patch fixes several warnings when compiling libavfilter with > current gcc. Ping. Should the warnings just stay? Thank you, Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH]configure: Add -Wno-main

2017-09-18 Thread Nicolas George
Le jour du Génie, an CCXXV, Clement Boesch a écrit : > I'm with James on this one, it's easy and harmless to fix, so I think > we should do that instead. I am also for changing the variable names. But it should also be reported to gcc, because this warning is utterly braindead for local symbols.

Re: [FFmpeg-devel] [PATCH]configure: Add -Wno-main

2017-09-18 Thread Carl Eugen Hoyos
2017-09-18 7:54 GMT+02:00 Clément Bœsch : > On Mon, Sep 18, 2017 at 03:55:12AM +0200, Carl Eugen Hoyos wrote: >> 2017-09-18 3:47 GMT+02:00 James Almer : >> > On 9/17/2017 10:37 PM, Carl Eugen Hoyos wrote: >> >> Hi! >> >> >> >> Attached patch fixes several warnings when compiling libavfilter with >>

Re: [FFmpeg-devel] [PATCH]configure: Add -Wno-main

2017-09-17 Thread Clément Bœsch
On Mon, Sep 18, 2017 at 03:55:12AM +0200, Carl Eugen Hoyos wrote: > 2017-09-18 3:47 GMT+02:00 James Almer : > > On 9/17/2017 10:37 PM, Carl Eugen Hoyos wrote: > >> Hi! > >> > >> Attached patch fixes several warnings when compiling libavfilter with > >> current gcc. > >> > >> Please comment, Carl Eu

Re: [FFmpeg-devel] [PATCH]configure: Add -Wno-main

2017-09-17 Thread Carl Eugen Hoyos
2017-09-18 3:47 GMT+02:00 James Almer : > On 9/17/2017 10:37 PM, Carl Eugen Hoyos wrote: >> Hi! >> >> Attached patch fixes several warnings when compiling libavfilter with >> current gcc. >> >> Please comment, Carl Eugen > > IMO, it would be better if we instead rename all the cases of "main" > use

Re: [FFmpeg-devel] [PATCH]configure: Add -Wno-main

2017-09-17 Thread James Almer
On 9/17/2017 10:37 PM, Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes several warnings when compiling libavfilter with > current gcc. > > Please comment, Carl Eugen IMO, it would be better if we instead rename all the cases of "main" used across the codebase. I'm surprised for that matte