Re: [FFmpeg-devel] [PATCH] sonic: use s->channels instead of avctx->channels

2015-06-09 Thread Andreas Cadhalpun
On 09.06.2015 23:04, Michael Niedermayer wrote: > On Tue, Jun 09, 2015 at 10:44:08PM +0200, Andreas Cadhalpun wrote: >> On 09.06.2015 22:30, Michael Niedermayer wrote: >>> On Tue, Jun 09, 2015 at 10:22:05PM +0200, Andreas Cadhalpun wrote: avctx->channels can be 0, causing SIGFPE crashes.

Re: [FFmpeg-devel] [PATCH] sonic: use s->channels instead of avctx->channels

2015-06-09 Thread Michael Niedermayer
On Tue, Jun 09, 2015 at 10:44:08PM +0200, Andreas Cadhalpun wrote: > On 09.06.2015 22:30, Michael Niedermayer wrote: > > On Tue, Jun 09, 2015 at 10:22:05PM +0200, Andreas Cadhalpun wrote: > >> avctx->channels can be 0, causing SIGFPE crashes. > >> > >> Signed-off-by: Andreas Cadhalpun > >> --- > >

Re: [FFmpeg-devel] [PATCH] sonic: use s->channels instead of avctx->channels

2015-06-09 Thread Andreas Cadhalpun
On 09.06.2015 22:30, Michael Niedermayer wrote: > On Tue, Jun 09, 2015 at 10:22:05PM +0200, Andreas Cadhalpun wrote: >> avctx->channels can be 0, causing SIGFPE crashes. >> >> Signed-off-by: Andreas Cadhalpun >> --- >> libavcodec/sonic.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: [FFmpeg-devel] [PATCH] sonic: use s->channels instead of avctx->channels

2015-06-09 Thread Michael Niedermayer
On Tue, Jun 09, 2015 at 10:22:05PM +0200, Andreas Cadhalpun wrote: > avctx->channels can be 0, causing SIGFPE crashes. > > Signed-off-by: Andreas Cadhalpun > --- > libavcodec/sonic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) i think avctx->channels should be set, channels is only