Jan Ekstrom gmail.com> writes:
> >> +int hdtv;
> >
> > Please rename to sdtv so you can remove the assignment
> > from init_decoder().
>
> What would that make of the default value?
The default value for (all) context variables is 0.
I am just trying to make the patch smaller, the
assignm
On Sat, Apr 23, 2016 at 2:33 PM, Jan Ekstrom wrote:
> On Sat, Apr 23, 2016 at 3:21 PM, wm4 wrote:
>> In that case the hdtv field should be completely removed, and the test
>> put in the palette conversion code.
>>
>
> If avctx->height is by default 0, then it would have to be something a la:
>
>
On Sat, Apr 23, 2016 at 3:21 PM, wm4 wrote:
> In that case the hdtv field should be completely removed, and the test
> put in the palette conversion code.
>
If avctx->height is by default 0, then it would have to be something a la:
if (!avctx->height || avctx->height > 576) {
YUV_TO_RGB1_CCI
On Sat, Apr 23, 2016 at 11:09 AM, Carl Eugen Hoyos wrote:
> Please mention the relevant ticket in the commit message.
OK, will do.
>
>> +int hdtv;
>
> Please rename to sdtv so you can remove the assignment from
> init_decoder().
>
What would that make of the default value? The current desig
On Sat, 23 Apr 2016 13:53:00 +0200
Hendrik Leppkes wrote:
> On Sat, Apr 23, 2016 at 1:18 PM, wm4 wrote:
> > On Fri, 22 Apr 2016 23:06:37 +0300
> > Jan Ekström wrote:
> >
> >> Functionality used before didn't widen the values from limited to
> >> full range. Additionally, now the decoder uses
On Sat, Apr 23, 2016 at 2:53 PM, Hendrik Leppkes wrote:
> Otherwise, I think Carl's suggestion might help, PGS subtitles are
> generally from Blu-rays, which means most of it is HD, so swapping the
> flag to detect SD conditions might make it act more "appropriate" in
> absence of w/h.
The defaul
On Sat, Apr 23, 2016 at 1:18 PM, wm4 wrote:
> On Fri, 22 Apr 2016 23:06:37 +0300
> Jan Ekström wrote:
>
>> Functionality used before didn't widen the values from limited to
>> full range. Additionally, now the decoder uses BT.709 where it
>> should be used according to the video resolution.
>>
>>
On Fri, 22 Apr 2016 23:06:37 +0300
Jan Ekström wrote:
> Functionality used before didn't widen the values from limited to
> full range. Additionally, now the decoder uses BT.709 where it
> should be used according to the video resolution.
>
> Default for not yet set colorimetry is BT.709 due to
Jan Ekström gmail.com> writes:
> Functionality used before didn't widen the values from limited to
> full range. Additionally, now the decoder uses BT.709 where it
> should be used according to the video resolution.
Please mention the relevant ticket in the commit message.
> +int hdtv;
Ple
