Re: [FFmpeg-devel] [PATCH] mxfdec.c: prefer metadata from Footer

2021-06-28 Thread emcodem
Am 2021-06-28 03:00, schrieb Marton Balint: On Sun, 27 Jun 2021, emco...@ffastrans.com wrote: Am 2021-06-27 20:12, schrieb Marton Balint: Why? I though it is enough if you store the partition number in the metadata set, that way you should be able to compare if the existing metadata set is bet

Re: [FFmpeg-devel] [PATCH] mxfdec.c: prefer metadata from Footer

2021-06-27 Thread Marton Balint
On Sun, 27 Jun 2021, emco...@ffastrans.com wrote: Am 2021-06-27 20:12, schrieb Marton Balint: Why? I though it is enough if you store the partition number in the metadata set, that way you should be able to compare if the existing metadata set is better than the current one when adding a new

Re: [FFmpeg-devel] [PATCH] mxfdec.c: prefer metadata from Footer

2021-06-27 Thread emcodem
Am 2021-06-27 20:12, schrieb Marton Balint: Why? I though it is enough if you store the partition number in the metadata set, that way you should be able to compare if the existing metadata set is better than the current one when adding a new metadata set. Or am I missing something? OK, i just

Re: [FFmpeg-devel] [PATCH] mxfdec.c: prefer metadata from Footer

2021-06-27 Thread emcodem
Am 2021-06-27 20:12, schrieb Marton Balint: On Sun, 27 Jun 2021, Tomas Härdin wrote: Order of parsing depends on the file, we usually do header, footer and then backwards the partitions. So after your patch metadata in the second partition will have priority over footer, which is also agains

Re: [FFmpeg-devel] [PATCH] mxfdec.c: prefer metadata from Footer

2021-06-27 Thread Marton Balint
On Sun, 27 Jun 2021, Tomas Härdin wrote: sön 2021-06-27 klockan 12:03 +0200 skrev Marton Balint: On Sat, 26 Jun 2021, emcodem wrote: > In case there is a Footer, regarding to SMPTE 377 all versions, the metadata in Footer shall be correct (where in Header it can be incomplete).. > If there

Re: [FFmpeg-devel] [PATCH] mxfdec.c: prefer metadata from Footer

2021-06-27 Thread Tomas Härdin
sön 2021-06-27 klockan 12:03 +0200 skrev Marton Balint: > > On Sat, 26 Jun 2021, emcodem wrote: > > > In case there is a Footer, regarding to SMPTE 377 all versions, the > > metadata in Footer shall be correct (where in Header it can be incomplete).. > > If there is no footer (stream, truncated.

Re: [FFmpeg-devel] [PATCH] mxfdec.c: prefer metadata from Footer

2021-06-27 Thread Marton Balint
On Sat, 26 Jun 2021, emcodem wrote: In case there is a Footer, regarding to SMPTE 377 all versions, the metadata in Footer shall be correct (where in Header it can be incomplete).. If there is no footer (stream, truncated...) it will still work as usual. Tested with a huge set of files and c