Re: [FFmpeg-devel] [PATCH] mov: Properly abide by the track's media duration

2018-04-19 Thread Derek Buitenhuis
On 4/18/2018 11:08 PM, Jan Ekström wrote: > Just an off-hand comment that given that audio frames in AAC tend to > have 1024 samples usually (or in more general, "1028 samples is quite > unlikely for AAC"), I'd say 1024 is correct for a duration of an AAC > frame. Looking at the hash, the actual da

Re: [FFmpeg-devel] [PATCH] mov: Properly abide by the track's media duration

2018-04-18 Thread Jan Ekström
On Thu, Apr 19, 2018 at 12:35 AM, Michael Niedermayer wrote: > > This breaks fate: (have not tested anything beyond this) > > TESTadtstoasc_ticket3715 > --- ./tests/ref/fate/adtstoasc_ticket3715 2018-04-17 14:20:30.500366780 > +0200 > +++ tests/data/fate/adtstoasc_ticket37152018

Re: [FFmpeg-devel] [PATCH] mov: Properly abide by the track's media duration

2018-04-18 Thread Michael Niedermayer
On Tue, Apr 17, 2018 at 08:59:48PM +0100, Derek Buitenhuis wrote: > The track's media duration from the mdhd atom takes precedence > over both the stts and elst atom for calculating and setting > the track's total duraion. > > Technically, we shouldn't be using the stts atom at all for > calculati