Re: [FFmpeg-devel] [PATCH] libvpx: Support setting color range for vp9.

2016-01-11 Thread Sasi Inguva
Thanks On Sat, Jan 9, 2016 at 7:53 AM, James Almer wrote: > On 1/9/2016 11:43 AM, Ronald S. Bultje wrote: > > Hi, > > > > On Fri, Jan 8, 2016 at 10:12 PM, Sasi Inguva wrote: > > > >> Pass through color range to vp9 encoder. Parse color range in > libvpxdec.c. > >> > >> Signed-off-by: Sasi Inguv

Re: [FFmpeg-devel] [PATCH] libvpx: Support setting color range for vp9.

2016-01-09 Thread James Almer
On 1/9/2016 11:43 AM, Ronald S. Bultje wrote: > Hi, > > On Fri, Jan 8, 2016 at 10:12 PM, Sasi Inguva wrote: > >> Pass through color range to vp9 encoder. Parse color range in libvpxdec.c. >> >> Signed-off-by: Sasi Inguva >> --- >> libavcodec/libvpxdec.c | 6 ++ >> libavcodec/libvpxenc.c |

Re: [FFmpeg-devel] [PATCH] libvpx: Support setting color range for vp9.

2016-01-09 Thread Ronald S. Bultje
Hi, On Fri, Jan 8, 2016 at 10:12 PM, Sasi Inguva wrote: > Pass through color range to vp9 encoder. Parse color range in libvpxdec.c. > > Signed-off-by: Sasi Inguva > --- > libavcodec/libvpxdec.c | 6 ++ > libavcodec/libvpxenc.c | 26 ++ > 2 files changed, 32 insert

Re: [FFmpeg-devel] [PATCH] libvpx: Support setting color range for vp9.

2016-01-08 Thread Sasi Inguva
Sorry for the delay on this. Was waiting for https://chromium-review.googlesource.com/#/c/320116/ to be submitted. Sent the new patch with decoder changes. On Mon, Jan 4, 2016 at 12:26 PM, James Almer wrote: > On 1/4/2016 5:01 PM, Sasi Inguva wrote: > > Would it be a lot easier and correct if I

Re: [FFmpeg-devel] [PATCH] libvpx: Support setting color range for vp9.

2016-01-07 Thread James Zern
Hi, On Mon, Jan 4, 2016 at 12:26 PM, James Almer wrote: > On 1/4/2016 5:01 PM, Sasi Inguva wrote: >> Would it be a lot easier and correct if I just update the IMAGE_ABI_VERSION >> to 4 in libvpx HEAD and check here in the decoder IMAGE_ABI_VERSION > 3 ? > > Yes, bumping any of the defines would

Re: [FFmpeg-devel] [PATCH] libvpx: Support setting color range for vp9.

2016-01-04 Thread James Almer
On 1/4/2016 5:01 PM, Sasi Inguva wrote: > Would it be a lot easier and correct if I just update the IMAGE_ABI_VERSION > to 4 in libvpx HEAD and check here in the decoder IMAGE_ABI_VERSION > 3 ? Yes, bumping any of the defines would probably be best. It will not apply to libvpxdec 1.5.0, though,

Re: [FFmpeg-devel] [PATCH] libvpx: Support setting color range for vp9.

2016-01-04 Thread Ronald S. Bultje
Hi Sasi, On Mon, Jan 4, 2016 at 3:01 PM, Sasi Inguva wrote: > Would it be a lot easier and correct if I just update the IMAGE_ABI_VERSION > to 4 in libvpx HEAD and check here in the decoder IMAGE_ABI_VERSION > 3 ? Sure, that's fine also. Ronald ___

Re: [FFmpeg-devel] [PATCH] libvpx: Support setting color range for vp9.

2016-01-04 Thread Sasi Inguva
Would it be a lot easier and correct if I just update the IMAGE_ABI_VERSION to 4 in libvpx HEAD and check here in the decoder IMAGE_ABI_VERSION > 3 ? On Mon, Jan 4, 2016 at 11:03 AM, Ronald S. Bultje wrote: > Hi, > > On Mon, Jan 4, 2016 at 1:48 PM, Sasi Inguva wrote: > > > Ping! I could not fi

Re: [FFmpeg-devel] [PATCH] libvpx: Support setting color range for vp9.

2016-01-04 Thread Ronald S. Bultje
Hi, On Mon, Jan 4, 2016 at 1:48 PM, Sasi Inguva wrote: > Ping! I could not find any other fields for version other than the > IMAGE_ABI_VERSION , CODEC_ABI_VERSION, DECODER_ABI_VERSION which remain > unchanged . So, add a version check? Or check for the existence of the appropriate color range

Re: [FFmpeg-devel] [PATCH] libvpx: Support setting color range for vp9.

2016-01-04 Thread Sasi Inguva
Ping! I could not find any other fields for version other than the IMAGE_ABI_VERSION , CODEC_ABI_VERSION, DECODER_ABI_VERSION which remain unchanged . On Wed, Dec 30, 2015 at 2:21 PM, Ronald S. Bultje wrote: > Hi, > > On Wed, Dec 30, 2015 at 3:46 PM, Sasi Inguva wrote: > > > VPX_IMAGE_ABI_VERSI

Re: [FFmpeg-devel] [PATCH] libvpx: Support setting color range for vp9.

2015-12-30 Thread Ronald S. Bultje
Hi, On Wed, Dec 30, 2015 at 3:46 PM, Sasi Inguva wrote: > VPX_IMAGE_ABI_VERSION was not changed when the color_range enum was > introduced so I am afraid I would have to drop libvpxdec changes. It should work in 1.5.0, no? So can't you do a version check? Ronald __

Re: [FFmpeg-devel] [PATCH] libvpx: Support setting color range for vp9.

2015-12-30 Thread Sasi Inguva
VPX_IMAGE_ABI_VERSION was not changed when the color_range enum was introduced so I am afraid I would have to drop libvpxdec changes. Sent the new patch On Wed, Dec 30, 2015 at 10:56 AM, James Almer wrote: > On 12/30/2015 3:47 PM, James Almer wrote: > > On 12/30/2015 3:23 PM, Sasi Inguva wrote:

Re: [FFmpeg-devel] [PATCH] libvpx: Support setting color range for vp9.

2015-12-30 Thread James Almer
On 12/30/2015 3:47 PM, James Almer wrote: > On 12/30/2015 3:23 PM, Sasi Inguva wrote: >> Pass through color range to vp9 encoder, and parse it in libvpxdec >> >> Signed-off-by: Sasi Inguva >> --- >> libavcodec/libvpxdec.c | 4 >> libavcodec/libvpxenc.c | 20 >> 2 files

Re: [FFmpeg-devel] [PATCH] libvpx: Support setting color range for vp9.

2015-12-30 Thread James Almer
On 12/30/2015 3:23 PM, Sasi Inguva wrote: > Pass through color range to vp9 encoder, and parse it in libvpxdec > > Signed-off-by: Sasi Inguva > --- > libavcodec/libvpxdec.c | 4 > libavcodec/libvpxenc.c | 20 > 2 files changed, 24 insertions(+) > > diff --git a/libavc