Re: [FFmpeg-devel] [PATCH] libswresample: Prevent out of bounds.

2023-08-02 Thread Michael Niedermayer
On Wed, Aug 02, 2023 at 03:14:10PM +0300, kobrineli wrote: > From: Eli Kobrin > > We've been fuzzing torchvision with > [sydr-fuzz](https://github.com/ispras/oss-sydr-fuzz) > and found out of bounds error in ffmpeg project at audioconvert.c:151. > To prevent error we need to fix checks for in an

Re: [FFmpeg-devel] [PATCH] libswresample: Prevent out of bounds.

2023-08-02 Thread kobrineli
Resubmitted, thanks On 2023-08-02 15:06, Ronald S. Bultje wrote: Hi, On Wed, Aug 2, 2023 at 7:31 AM kobrineli wrote: From: Eli Kobrin We've been fuzzing torchvision with [sydr-fuzz]( https://github.com/ispras/oss-sydr-fuzz) and found out of bounds error in ffmpeg project at audioconvert.c:

Re: [FFmpeg-devel] [PATCH] libswresample: Prevent out of bounds.

2023-08-02 Thread Ronald S. Bultje
Hi, On Wed, Aug 2, 2023 at 7:31 AM kobrineli wrote: > From: Eli Kobrin > > We've been fuzzing torchvision with [sydr-fuzz]( > https://github.com/ispras/oss-sydr-fuzz) > and found out of bounds error in ffmpeg project at audioconvert.c:51. > To prevent error we need to insert corresponding check

Re: [FFmpeg-devel] [PATCH] libswresample: Prevent out of bounds.

2023-08-02 Thread kobrineli
Resubmitted the patch (https://patchwork.ffmpeg.org/project/ffmpeg/patch/20230802113106.1138555-1-kobrin...@ispras.ru/). Didn't understand how to fix the existing patch. On 2023-08-02 13:51, Andreas Rheinhardt wrote: kobrineli: From: Eli Kobrin We've been fuzzing torchvision with [sydr-fuzz

Re: [FFmpeg-devel] [PATCH] libswresample: Prevent out of bounds.

2023-08-02 Thread kobrineli
I've found out that `in_fmt` is equal to -1 at the place of error, so we just need to insert check at the beginning of `swr_init` function to check fmts positivity. On 2023-08-02 13:51, Andreas Rheinhardt wrote: kobrineli: From: Eli Kobrin We've been fuzzing torchvision with [sydr-fuzz](

Re: [FFmpeg-devel] [PATCH] libswresample: Prevent out of bounds.

2023-08-02 Thread kobrineli
Invalid out or int fmts are got from the user input, which was discovered through fuzzing. Don't know where to add check at the time of SwrContext creating, but I think this change is redundant to at least prevent dangerous out of bounds access, which set the pointer to illegal address. On 20

Re: [FFmpeg-devel] [PATCH] libswresample: Prevent out of bounds.

2023-08-02 Thread Andreas Rheinhardt
kobrineli: > From: Eli Kobrin > > We've been fuzzing torchvision with > [sydr-fuzz](https://github.com/ispras/oss-sydr-fuzz) > and found out of bounds error in ffmpeg project at audioconvert.c:51. > To prevent error we need to insert corresponding check. > > Signed-off-by: Eli Kobrin > --- >