Re: [FFmpeg-devel] [PATCH] libopus: support disabling phase inversion.

2018-01-22 Thread Rostislav Pehlivanov
On 22 January 2018 at 15:16, wrote: > From: Menno > > Signed-off-by: Menno > --- > doc/encoders.texi | 5 + > libavcodec/libopusenc.c | 14 ++ > 2 files changed, 19 insertions(+) > > diff --git a/doc/encoders.texi b/doc/encoders.texi > index 6a410a8cb6..5cd8b1a064 100644

Re: [FFmpeg-devel] [PATCH] libopus: support disabling phase inversion.

2018-01-22 Thread Carl Eugen Hoyos
2018-01-22 16:16 GMT+01:00 : > +#ifdef OPUS_SET_PHASE_INVERSION_DISABLED_REQUEST > +{ "disable_phase_inversion", "Disable phase inversion", > OFFSET(disable_phase_inversion), > AV_OPT_TYPE_INT, { .i64 = 0 }, 0, 1, FLAGS }, One possibility is an option "phase_inversion" t

Re: [FFmpeg-devel] [PATCH] libopus: support disabling phase inversion.

2018-01-22 Thread Derek Buitenhuis
On 1/22/2018 4:46 PM, Paul B Mahol wrote: > NACK. > > Option name is too loong, and its type is not boolean. Opinions on what to call it welcome. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-de

Re: [FFmpeg-devel] [PATCH] libopus: support disabling phase inversion.

2018-01-22 Thread Paul B Mahol
On 1/22/18, mrdeg...@gmail.com wrote: > From: Menno > > Signed-off-by: Menno > --- > doc/encoders.texi | 5 + > libavcodec/libopusenc.c | 14 ++ > 2 files changed, 19 insertions(+) > > diff --git a/doc/encoders.texi b/doc/encoders.texi > index 6a410a8cb6..5cd8b1a064 10064

Re: [FFmpeg-devel] [PATCH] libopus: support disabling phase inversion.

2018-01-22 Thread Derek Buitenhuis
On 1/22/2018 3:16 PM, mrdeg...@gmail.com wrote: > From: Menno > > Signed-off-by: Menno > --- > doc/encoders.texi | 5 + > libavcodec/libopusenc.c | 14 ++ > 2 files changed, 19 insertions(+) > > diff --git a/doc/encoders.texi b/doc/encoders.texi > index 6a410a8cb6..5cd8b