Re: [FFmpeg-devel] [PATCH] libavformat/mov: Speed up fragmented mp4 parsing (Take 2)

2018-11-13 Thread Aaron Boushley
On Mon, Nov 5, 2018 at 3:48 PM Aaron Boushley wrote: > > Sorry for the second thread, first one was corrupted with a newline > because I attempted an inline patch. Hopefully the mime-type will be set > correctly on this one. > --- > When parsing a fragmented MP4 with the use_mfra_for option set so

Re: [FFmpeg-devel] [PATCH] libavformat/mov: Speed up fragmented mp4 parsing

2018-11-05 Thread Aaron Boushley
On Mon, Nov 5, 2018 at 3:25 PM Aaron Boushley wrote: > > On Mon, Nov 5, 2018 at 3:13 PM Carl Eugen Hoyos wrote: > > > > 2018-11-06 0:03 GMT+01:00, Aaron Boushley : > > > On Mon, Nov 5, 2018 at 2:21 PM Michael Niedermayer > > > wrote: > > > > >> > diff --git a/libavformat/mov.c b/libavformat/mov.

Re: [FFmpeg-devel] [PATCH] libavformat/mov: Speed up fragmented mp4 parsing

2018-11-05 Thread Aaron Boushley
On Mon, Nov 5, 2018 at 3:13 PM Carl Eugen Hoyos wrote: > > 2018-11-06 0:03 GMT+01:00, Aaron Boushley : > > On Mon, Nov 5, 2018 at 2:21 PM Michael Niedermayer > > wrote: > > >> > diff --git a/libavformat/mov.c b/libavformat/mov.c > >> > index ec57a05803..1def594626 100644 > >> > --- a/libavformat/

Re: [FFmpeg-devel] [PATCH] libavformat/mov: Speed up fragmented mp4 parsing

2018-11-05 Thread Carl Eugen Hoyos
2018-11-06 0:03 GMT+01:00, Aaron Boushley : > On Mon, Nov 5, 2018 at 2:21 PM Michael Niedermayer > wrote: >> > diff --git a/libavformat/mov.c b/libavformat/mov.c >> > index ec57a05803..1def594626 100644 >> > --- a/libavformat/mov.c >> > +++ b/libavformat/mov.c >> > @@ -7344,6 +7344,8 @@ static in

Re: [FFmpeg-devel] [PATCH] libavformat/mov: Speed up fragmented mp4 parsing

2018-11-05 Thread Aaron Boushley
On Mon, Nov 5, 2018 at 2:21 PM Michael Niedermayer wrote: > > On Mon, Nov 05, 2018 at 11:17:25AM -0800, Aaron Boushley wrote: > > When parsing a fragmented MP4 with the use_mfra_for option set so that > > the mfra box is parsed we currently continue to parse all the top level > > boxes in the mp4.

Re: [FFmpeg-devel] [PATCH] libavformat/mov: Speed up fragmented mp4 parsing

2018-11-05 Thread Michael Niedermayer
On Mon, Nov 05, 2018 at 11:17:25AM -0800, Aaron Boushley wrote: > When parsing a fragmented MP4 with the use_mfra_for option set so that > the mfra box is parsed we currently continue to parse all the top level > boxes in the mp4. We also avoid using the index in mov_seek_fragment > unless the frag