Re: [FFmpeg-devel] [PATCH] libavcodec: QSV protect GPB code with CO3 define

2019-04-29 Thread Li, Zhong
> > But the CODE doesn't say that! > > > > The code uses: > > "#if QSV_HAVE_CO3" > > > > And then every use of the "co3" member needs to be protected by this > clausule. > > Futhermore, this is true in every part of the source code in > > "qsvenc.c"... except at two points (I need to review my patc

Re: [FFmpeg-devel] [PATCH] libavcodec: QSV protect GPB code with CO3 define

2019-04-23 Thread Andreas Håkon
‐‐‐ Original Message ‐‐‐ On Tuesday, 23 de April de 2019 9:29, Andreas Håkon wrote: > ‐‐‐ Original Message ‐‐‐ > On Tuesday, 23 de April de 2019 8:39, Li, Zhong zhong...@intel.com wrote: > > > I belive they are different. If you extend the MARCIO, they are actually: > > IMHO, yo

Re: [FFmpeg-devel] [PATCH] libavcodec: QSV protect GPB code with CO3 define

2019-04-23 Thread Andreas Håkon
‐‐‐ Original Message ‐‐‐ On Tuesday, 23 de April de 2019 8:39, Li, Zhong wrote: > > I belive they are different. If you extend the MARCIO, they are actually: > > > IMHO, your patch is only needed when disable "QSV_HAVE_CO3", but tiket#7839 > is not root caused now. > I will consider to a

Re: [FFmpeg-devel] [PATCH] libavcodec: QSV protect GPB code with CO3 define

2019-04-22 Thread Li, Zhong
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Andreas Håkon > Sent: Monday, April 22, 2019 8:21 PM > To: FFmpeg development discussions and patches > > Subject: Re: [FFmpeg-devel] [PATCH] libavcodec: QSV protec

Re: [FFmpeg-devel] [PATCH] libavcodec: QSV protect GPB code with CO3 define

2019-04-22 Thread myp...@gmail.com
On Mon, Apr 22, 2019 at 8:42 PM Andreas Håkon wrote: > > > ‐‐‐ Original Message ‐‐‐ > On Monday, 22 de April de 2019 14:17, myp...@gmail.com > wrote: > > > On Mon, Apr 22, 2019 at 7:38 PM Li, Zhong zhong...@intel.com wrote: > > > > > > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmp

Re: [FFmpeg-devel] [PATCH] libavcodec: QSV protect GPB code with CO3 define

2019-04-22 Thread Andreas Håkon
‐‐‐ Original Message ‐‐‐ On Monday, 22 de April de 2019 14:17, myp...@gmail.com wrote: > On Mon, Apr 22, 2019 at 7:38 PM Li, Zhong zhong...@intel.com wrote: > > > > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > > > Of Andreas Håkon via ffmpeg-devel > > > Sent: T

Re: [FFmpeg-devel] [PATCH] libavcodec: QSV protect GPB code with CO3 define

2019-04-22 Thread myp...@gmail.com
On Mon, Apr 22, 2019 at 7:38 PM Li, Zhong wrote: > > > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > > Of Andreas Håkon via ffmpeg-devel > > Sent: Thursday, April 18, 2019 6:11 PM > > To: FFmpeg development discussions and patches > > > > Cc: Andreas Håkon > > Subject:

Re: [FFmpeg-devel] [PATCH] libavcodec: QSV protect GPB code with CO3 define

2019-04-22 Thread Andreas Håkon
‐‐‐ Original Message ‐‐‐ On Monday, 22 de April de 2019 13:33, Li, Zhong wrote: > > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > > Of Andreas Håkon via ffmpeg-devel > > Sent: Thursday, April 18, 2019 6:11 PM > > To: FFmpeg development discussions and patches >

Re: [FFmpeg-devel] [PATCH] libavcodec: QSV protect GPB code with CO3 define

2019-04-22 Thread Li, Zhong
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Andreas Håkon via ffmpeg-devel > Sent: Thursday, April 18, 2019 6:11 PM > To: FFmpeg development discussions and patches > > Cc: Andreas Håkon > Subject: [FFmpeg-devel] [PATCH] libavcodec: QSV protect GPB code with > CO3