Re: [FFmpeg-devel] [PATCH] libavcodec/pgx: Added pgx decoder

2020-06-27 Thread Gautam Ramakrishnan
On Sat, Jun 27, 2020 at 6:06 PM Nicolas George wrote: > > Gautam Ramakrishnan (12020-06-27): > > This will require me to remove the decode_header() function and add the > > logic directly into the decode_frame function. If that is fine, I shall > > remove > > PGX context structrure. > > No, it re

Re: [FFmpeg-devel] [PATCH] libavcodec/pgx: Added pgx decoder

2020-06-27 Thread Nicolas George
Gautam Ramakrishnan (12020-06-27): > This will require me to remove the decode_header() function and add the > logic directly into the decode_frame function. If that is fine, I shall remove > PGX context structrure. No, it requires nothing of the sort. You can pass pointers to the individual varia

Re: [FFmpeg-devel] [PATCH] libavcodec/pgx: Added pgx decoder

2020-06-27 Thread Gautam Ramakrishnan
On Sat, Jun 27, 2020 at 5:45 PM Nicolas George wrote: > > Gautam Ramakrishnan (12020-06-25): > > The type conversions confused me a bit. I will remove them. > > Please be sure you have the basics about C type promotions right. C will > automatically convert types whenever necessary and notify when

Re: [FFmpeg-devel] [PATCH] libavcodec/pgx: Added pgx decoder

2020-06-27 Thread Nicolas George
Gautam Ramakrishnan (12020-06-25): > The type conversions confused me a bit. I will remove them. Please be sure you have the basics about C type promotions right. C will automatically convert types whenever necessary and notify when one such conversion may cause unexpected results. Adding a cast w

Re: [FFmpeg-devel] [PATCH] libavcodec/pgx: Added pgx decoder

2020-06-26 Thread Gautam Ramakrishnan
On Fri, Jun 26, 2020 at 3:50 AM Carl Eugen Hoyos wrote: > > Am Do., 25. Juni 2020 um 09:23 Uhr schrieb Gautam Ramakrishnan > : > > > > On Thu, Jun 25, 2020 at 12:50 AM Carl Eugen Hoyos > > wrote: > > > > > +for (i = 0; i < 6; i++) { > > > > +if (header_start[i] != (char)bytestream2_g

Re: [FFmpeg-devel] [PATCH] libavcodec/pgx: Added pgx decoder

2020-06-25 Thread Carl Eugen Hoyos
Am Do., 25. Juni 2020 um 09:23 Uhr schrieb Gautam Ramakrishnan : > > On Thu, Jun 25, 2020 at 12:50 AM Carl Eugen Hoyos wrote: > > > +for (i = 0; i < 6; i++) { > > > +if (header_start[i] != (char)bytestream2_get_byteu(&s->g)) { > > > +return AVERROR_INVALIDDATA; > > > +

Re: [FFmpeg-devel] [PATCH] libavcodec/pgx: Added pgx decoder

2020-06-25 Thread Gautam Ramakrishnan
On Thu, Jun 25, 2020 at 12:50 AM Carl Eugen Hoyos wrote: > > Am Mi., 24. Juni 2020 um 20:55 Uhr schrieb : > > > > From: Gautam Ramakrishnan > > > > This patch support to read and decode > > pgx files. > > --- > > libavcodec/Makefile | 1 + > > libavcodec/allcodecs.c | 1 + > > libavco

Re: [FFmpeg-devel] [PATCH] libavcodec/pgx: Added pgx decoder

2020-06-24 Thread Gautam Ramakrishnan
On Thu, Jun 25, 2020 at 12:43 AM Nicolas George wrote: > > Thanks for the patch. Here are a few preliminary remarks. > > gautamr...@gmail.com (12020-06-24): > > From: Gautam Ramakrishnan > > > > This patch support to read and decode > > pgx files. > > --- > > libavcodec/Makefile | 1 + > >

Re: [FFmpeg-devel] [PATCH] libavcodec/pgx: Added pgx decoder

2020-06-24 Thread Moritz Barsnick
On Thu, Jun 25, 2020 at 00:52:57 +0200, Carl Eugen Hoyos wrote: > Am Do., 25. Juni 2020 um 00:12 Uhr schrieb Moritz Barsnick : > > What about LM? Or do little-endian samples not exist? > There are only 78 known samples, all from the jpeg2000 test suite. Okay, that makes this a fringe feature. I f

Re: [FFmpeg-devel] [PATCH] libavcodec/pgx: Added pgx decoder

2020-06-24 Thread Carl Eugen Hoyos
Am Do., 25. Juni 2020 um 00:12 Uhr schrieb Moritz Barsnick : > > On Wed, Jun 24, 2020 at 23:57:10 +0530, gautamr...@gmail.com wrote: > > +const char *header_start = "PG ML "; > > What about LM? Or do little-endian samples not exist? There are only 78 known samples, all from the jpeg2000 test s

Re: [FFmpeg-devel] [PATCH] libavcodec/pgx: Added pgx decoder

2020-06-24 Thread Moritz Barsnick
On Wed, Jun 24, 2020 at 23:57:10 +0530, gautamr...@gmail.com wrote: > +const char *header_start = "PG ML "; What about LM? Or do little-endian samples not exist? > +if (bytestream2_peek_byte(&s->g) == ' ') > +bytestream2_skip(&s->g, 1); I understand the separators can also be tab

Re: [FFmpeg-devel] [PATCH] libavcodec/pgx: Added pgx decoder

2020-06-24 Thread Carl Eugen Hoyos
Am Mi., 24. Juni 2020 um 20:55 Uhr schrieb : > > From: Gautam Ramakrishnan > > This patch support to read and decode > pgx files. > --- > libavcodec/Makefile | 1 + > libavcodec/allcodecs.c | 1 + > libavcodec/codec_id.h| 1 + > libavcodec/pgx.h | 38 + > libavco

Re: [FFmpeg-devel] [PATCH] libavcodec/pgx: Added pgx decoder

2020-06-24 Thread Nicolas George
Thanks for the patch. Here are a few preliminary remarks. gautamr...@gmail.com (12020-06-24): > From: Gautam Ramakrishnan > > This patch support to read and decode > pgx files. > --- > libavcodec/Makefile | 1 + > libavcodec/allcodecs.c | 1 + > libavcodec/codec_id.h| 1 + > li

Re: [FFmpeg-devel] [PATCH] libavcodec/pgx: Added pgx decoder

2020-06-24 Thread Gautam Ramakrishnan
On Wed, Jun 24, 2020 at 11:54 PM wrote: > > From: Gautam Ramakrishnan > > This patch support to read and decode > pgx files. > --- > libavcodec/Makefile | 1 + > libavcodec/allcodecs.c | 1 + > libavcodec/codec_id.h| 1 + > libavcodec/pgx.h | 38 + > libavcodec/