Re: [FFmpeg-devel] [PATCH] libavcodec/libfdk-aacenc: Enable writing DRC metadata

2023-02-28 Thread Martin Storsjö
On Tue, 28 Feb 2023, Jonathan Gee wrote: Looks mostly good to me now, thanks. I guess I can clean up the remaining few nitpicks without you having to resubmit the patch. So unless you disagree with the comments, I can push it with the minor touch-ups. // Martin Sounds good to me. No disagre

Re: [FFmpeg-devel] [PATCH] libavcodec/libfdk-aacenc: Enable writing DRC metadata

2023-02-28 Thread Jonathan Gee
> Looks mostly good to me now, thanks. I guess I can clean up the remaining > few nitpicks without you having to resubmit the patch. So unless you > disagree with the comments, I can push it with the minor touch-ups. > > // Martin > Sounds good to me. No disagreements here. Thank you for going o

Re: [FFmpeg-devel] [PATCH] libavcodec/libfdk-aacenc: Enable writing DRC metadata

2023-02-28 Thread Martin Storsjö
On Tue, 28 Feb 2023, JonHGee wrote: Signed-off-by: JonHGee --- libavcodec/libfdk-aacenc.c | 69 +++--- 1 file changed, 56 insertions(+), 13 deletions(-) diff --git a/libavcodec/libfdk-aacenc.c b/libavcodec/libfdk-aacenc.c index 54549de473..123dabf3ae 100644 --- a

Re: [FFmpeg-devel] [PATCH] libavcodec/libfdk-aacenc: Enable writing DRC metadata

2023-02-28 Thread Martin Storsjö
On Mon, 27 Feb 2023, JonHGee wrote: Added basic DRC options and ref levels to AV options. If any options are selected, metadata mode is set accordingly and metadata is added to input buffer per FDK encoder API. --- libavcodec/libfdk-aacenc.c | 72 ++ 1 file ch