Re: [FFmpeg-devel] [PATCH] lavu/hwcontext_vaapi: Skip 'vgem' driver

2022-12-05 Thread Brian Norris
On Mon, Dec 05, 2022 at 04:37:29AM +, Xiang, Haihao wrote: > On Wed, 2022-11-23 at 13:54 -0800, Brian Norris wrote: > > +} else if (!strncmp(info->name, "vgem", 4)) { > > The virtual GEM device is vgem, so better to use strcmp here. Good point, we probably shouldn't be matchi

Re: [FFmpeg-devel] [PATCH] lavu/hwcontext_vaapi: Skip 'vgem' driver

2022-12-04 Thread Xiang, Haihao
On Wed, 2022-11-23 at 13:54 -0800, Brian Norris wrote: > There can be more than one available render node, and it's not > guaranteed the first node we come across is the correct one. In > particular, 'vgem' devices are common, and are > never VAAPI-enabled and thus not valid here. > > We have a 'k

Re: [FFmpeg-devel] [PATCH] lavu/hwcontext_vaapi: Skip 'vgem' driver

2022-11-29 Thread Brian Norris
Hi Anton, On Tue, Nov 29, 2022 at 12:25:11PM +0100, Anton Khirnov wrote: > I'm not the maintainer for this, but I wonder if it wouldn't be cleaner > to instead add something like a 'kernel_driver_blacklist' option that > would contain a comma-separated list of ignored drivers, and default to > 'vg

Re: [FFmpeg-devel] [PATCH] lavu/hwcontext_vaapi: Skip 'vgem' driver

2022-11-29 Thread Anton Khirnov
Quoting Brian Norris (2022-11-23 22:54:44) > There can be more than one available render node, and it's not > guaranteed the first node we come across is the correct one. In > particular, 'vgem' devices are common, and are > never VAAPI-enabled and thus not valid here. > > We have a 'kernel_driver