Re: [FFmpeg-devel] [PATCH] lavf/tee: fix side data double free.

2015-12-13 Thread Michael Niedermayer
On Sat, Oct 10, 2015 at 07:13:04PM +0200, Nicolas George wrote: > Le nonidi 19 vendémiaire, an CCXXIV, wm4 a écrit : > > This looks suspicious. Like some code above this does unclean tricks > > with keeping side-data somehow referenced, instead of using proper > > methods like creating a new AVPack

Re: [FFmpeg-devel] [PATCH] lavf/tee: fix side data double free.

2015-10-10 Thread Nicolas George
Le nonidi 19 vendémiaire, an CCXXIV, wm4 a écrit : > This looks suspicious. Like some code above this does unclean tricks > with keeping side-data somehow referenced, instead of using proper > methods like creating a new AVPacket reference. It is the same code than in ffmpeg.c, but I must admit I

Re: [FFmpeg-devel] [PATCH] lavf/tee: fix side data double free.

2015-10-10 Thread wm4
On Sat, 10 Oct 2015 15:19:43 +0200 Nicolas George wrote: > Similar to 33fefdb44. > Fix trac ticket #4921. > > Signed-off-by: Nicolas George > --- > libavformat/tee.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavformat/tee.c b/libavformat/tee.c > index c619eae..a86952b 10064

Re: [FFmpeg-devel] [PATCH] lavf/tee: fix side data double free.

2015-10-10 Thread Ganesh Ajjanagadde
On Sat, Oct 10, 2015 at 9:19 AM, Nicolas George wrote: > Similar to 33fefdb44. > Fix trac ticket #4921. > > Signed-off-by: Nicolas George > --- > libavformat/tee.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavformat/tee.c b/libavformat/tee.c > index c619eae..a86952b 100644 > -