On Fri, Oct 21, 2016 at 6:32 PM, Derek Buitenhuis
wrote:
> The design one fist: This approach is fundamentally wrong. Edit lists are
> meant to be applied at presentation level, not packet level. The current
> implementation will cause problems in a number of cases:
>
> * Audio packets. Especi
On 11/12/16, Sasi Inguva wrote:
> The above file has an edit list with duration zero .
>
> *
> Even quick time player doesn't play the video.
>
> Enabling the old code to populate skip_samples by looking at first edit
> list duration, when -ignore_editlist is true is a good fallback. I'll send
>
The above file has an edit list with duration zero .
Even quick time player doesn't play the video.
Enabling the old code to populate skip_samples by looking at first edit
list duration, when -ignore_editlist is true is a good fallback. I'll send
a commit soon.
On Fri, Nov 11, 2016 at 11:08 P
On Fri, 5 Aug 2016 17:18:39 -0700
Sasi Inguva wrote:
> In YouTube we have long been receiving MOV files from users, which have
> non-trivial edit lists (Those edit
Found a file that does not show video at all with edit lists enabled:
https://0x0.st/2Ep.mp4
You can test e.g. in ffplay. There'
On 10/24/2016 6:43 AM, Sasi Inguva wrote:
> Just sent a patch, correcting a bug in the edit list code. PTAL.
Hi again, it's me. Back with more files this patch set broke :).
This time it's very easy to reproduce:
$ ffmpeg -i sample.mp4 -f null -
This works before your patchset, and also if
Just sent a patch, correcting a bug in the edit list code. PTAL.
On Fri, Oct 21, 2016 at 11:08 AM, Derek Buitenhuis <
derek.buitenh...@gmail.com> wrote:
> On 10/21/2016 6:47 PM, Sasi Inguva wrote:
> > * Audio packets. Especially audio packets with a large number of
> samples.
> >
On 10/21/2016 6:47 PM, Sasi Inguva wrote:
> * Audio packets. Especially audio packets with a large number of
> samples.
> It's extremely likely that edits will not fall on packet
> boundaries, and
> depending on the number of samples per packet, audio sync issues
> ca
On Fri, Oct 21, 2016 at 8:32 AM, Derek Buitenhuis <
derek.buitenh...@gmail.com> wrote:
> > In YouTube we have long been receiving MOV files from users, which have
> non-trivial edit lists (Those edit lists which are not just used to offset
> video start from audio start) and multiple edit lists. R
On Fri, 21 Oct 2016 16:59:14 +0100
Derek Buitenhuis wrote:
> On 10/21/2016 4:32 PM, Derek Buitenhuis wrote:
> > * Audio packets. Especially audio packets with a large number of
> > samples.
> > It's extremely likely that edits will not fall on packet boundaries,
> > and
> > depe
On 10/21/2016 4:32 PM, Derek Buitenhuis wrote:
> * Audio packets. Especially audio packets with a large number of samples.
> It's extremely likely that edits will not fall on packet boundaries, and
> depending on the number of samples per packet, audio sync issues can and
> wi
> In YouTube we have long been receiving MOV files from users, which have
> non-trivial edit lists (Those edit lists which are not just used to offset
> video start from audio start) and multiple edit lists. Recently the uploads
> of such files has increased with the introduction of apps that al
On Tue, Oct 18, 2016 at 10:10 PM, Sasi Inguva <
isasi-at-google@ffmpeg.org> wrote:
> I am also happy to fix any breaking files, if they don't fall under the
> above category.
>
>
>
The change seems to have caused resulting files to have incorrect duration
in some cases (remuxing XDCAM material
On Tue, 18 Oct 2016 13:08:07 -0700
Sasi Inguva wrote:
> With the current state of code, we will only encounterdemuxer
> outputting non-monotonic DTS when there are multiple edit lists . Avoiding
> non-monotonic DTS for mulitple edit lists will not be possible with how the
> edit list support
I am also happy to fix any breaking files, if they don't fall under the
above category.
On Tue, Oct 18, 2016 at 1:08 PM, Sasi Inguva wrote:
> With the current state of code, we will only encounterdemuxer
> outputting non-monotonic DTS when there are multiple edit lists . Avoiding
> non-mono
With the current state of code, we will only encounterdemuxer
outputting non-monotonic DTS when there are multiple edit lists . Avoiding
non-monotonic DTS for mulitple edit lists will not be possible with how the
edit list support is currently implemented. That would only be possible if
the ed
On Fri, 5 Aug 2016 17:18:39 -0700
Sasi Inguva wrote:
> In YouTube we have long been receiving MOV files from users, which have
> non-trivial edit lists (Those edit lists which are not just used to offset
> video start from audio start) and multiple edit lists. Recently the uploads
> of such f
Oops. I messed up with git send-email, and my message didn't occur in
reply to this thread. So, here I am typing in Gmail..
Hi Clement and Michael,
Sorry that I hadn't started a discussion on the patch before sending it for
review. However this patch has been there for years in our ffmpeg versio
Hi,
On Fri, Aug 05, 2016 at 05:18:39PM -0700, Sasi Inguva wrote:
> In YouTube we have long been receiving MOV files from users, which have
> non-trivial edit lists (Those edit lists which are not just used to offset
> video start from audio start) and multiple edit lists. Recently the uploads
>
On Fri, Aug 05, 2016 at 05:18:40PM -0700, Sasi Inguva wrote:
> Signed-off-by: Sasi Inguva
> ---
> libavcodec/avcodec.h | 6 +
> libavcodec/utils.c | 6 +
> libavformat/avformat.h | 3 +
> libavformat/mov.c
On Fri, Aug 05, 2016 at 05:18:40PM -0700, Sasi Inguva wrote:
> Signed-off-by: Sasi Inguva
> ---
> libavcodec/avcodec.h | 6 +
> libavcodec/utils.c | 6 +
> libavformat/avformat.h | 3 +
> libavformat/mov.c
20 matches
Mail list logo
