Re: [FFmpeg-devel] [PATCH] lavc/binkaudio: reset input packet on errors

2023-06-17 Thread Paul B Mahol
On Sat, Jun 17, 2023 at 9:47 AM Anton Khirnov wrote: > Quoting Paul B Mahol (2023-06-17 09:39:24) > > On Sat, Jun 17, 2023 at 9:16 AM Anton Khirnov wrote: > > > > > Quoting Paul B Mahol (2023-06-17 08:35:21) > > > > On Sat, Jun 17, 2023 at 4:54 AM Anton Khirnov > wrote: > > > > > > > > > Make s

Re: [FFmpeg-devel] [PATCH] lavc/binkaudio: reset input packet on errors

2023-06-17 Thread Anton Khirnov
Quoting Paul B Mahol (2023-06-17 09:39:24) > On Sat, Jun 17, 2023 at 9:16 AM Anton Khirnov wrote: > > > Quoting Paul B Mahol (2023-06-17 08:35:21) > > > On Sat, Jun 17, 2023 at 4:54 AM Anton Khirnov wrote: > > > > > > > Make sure we don't repeatedly try to decode the same packet, making no > > >

Re: [FFmpeg-devel] [PATCH] lavc/binkaudio: reset input packet on errors

2023-06-17 Thread Paul B Mahol
On Sat, Jun 17, 2023 at 9:16 AM Anton Khirnov wrote: > Quoting Paul B Mahol (2023-06-17 08:35:21) > > On Sat, Jun 17, 2023 at 4:54 AM Anton Khirnov wrote: > > > > > Make sure we don't repeatedly try to decode the same packet, making no > > > progress and possibly causing an infinite loop. > > >

Re: [FFmpeg-devel] [PATCH] lavc/binkaudio: reset input packet on errors

2023-06-17 Thread Anton Khirnov
Quoting Paul B Mahol (2023-06-17 08:35:21) > On Sat, Jun 17, 2023 at 4:54 AM Anton Khirnov wrote: > > > Make sure we don't repeatedly try to decode the same packet, making no > > progress and possibly causing an infinite loop. > > > > Doesn't all error paths, bellow goto label in function, needs

Re: [FFmpeg-devel] [PATCH] lavc/binkaudio: reset input packet on errors

2023-06-16 Thread Paul B Mahol
On Sat, Jun 17, 2023 at 4:54 AM Anton Khirnov wrote: > Make sure we don't repeatedly try to decode the same packet, making no > progress and possibly causing an infinite loop. > Doesn't all error paths, bellow goto label in function, needs this (reset of ch_offset to 0 and unref of pkt) ? > --