Re: [FFmpeg-devel] [PATCH] lavc/audiotoolboxenc: fix dropped frames on iOS

2016-06-09 Thread Rodger Combs
One comment below; otherwise this LGTM. > On Jun 2, 2016, at 01:32, Rick Kern wrote: > > AudioConverterFillComplexBuffer() doesn't always call its callback. A frame > queue is used to prevent skipped audio samples. > > Signed-off-by: Rick Kern > --- > libavcodec/audiotoolboxenc.c | 78

Re: [FFmpeg-devel] [PATCH] lavc/audiotoolboxenc: fix dropped frames on iOS

2016-06-09 Thread Richard Kern
> On Jun 2, 2016, at 2:32 AM, Rick Kern wrote: > > AudioConverterFillComplexBuffer() doesn't always call its callback. A frame > queue is used to prevent skipped audio samples. > > Signed-off-by: Rick Kern > --- > libavcodec/audiotoolboxenc.c | 78 +--- >

Re: [FFmpeg-devel] [PATCH] lavc/audiotoolboxenc: fix dropped frames on iOS

2016-06-07 Thread Richard Kern
Ping. > On Jun 2, 2016, at 2:32 AM, Rick Kern wrote: > > AudioConverterFillComplexBuffer() doesn't always call its callback. A frame > queue is used to prevent skipped audio samples. > > Signed-off-by: Rick Kern > --- > libavcodec/audiotoolboxenc.c | 78 +---