Re: [FFmpeg-devel] [PATCH] frame_thread_encoder: make task indexing deterministic.

2017-04-03 Thread Michael Niedermayer
On Sun, Apr 02, 2017 at 07:30:00AM -0400, Ronald S. Bultje wrote: > Hi, > > On Sat, Apr 1, 2017 at 8:19 PM, Michael Niedermayer > wrote: > > > Supporting changing delay and number of threads at runtime was a > > big factor in the design of the frame thread encoder. Its something > > i cared abou

Re: [FFmpeg-devel] [PATCH] frame_thread_encoder: make task indexing deterministic.

2017-04-02 Thread Ronald S. Bultje
Hi, On Sat, Apr 1, 2017 at 8:19 PM, Michael Niedermayer wrote: > Supporting changing delay and number of threads at runtime was a > big factor in the design of the frame thread encoder. Its something > i cared about, so i am not to positive towards patches removing that. It introduced a bug. I

Re: [FFmpeg-devel] [PATCH] frame_thread_encoder: make task indexing deterministic.

2017-04-01 Thread Michael Niedermayer
On Sat, Apr 01, 2017 at 06:34:50PM -0400, Ronald S. Bultje wrote: > Hi, > > On Sat, Apr 1, 2017 at 5:44 PM, Michael Niedermayer > wrote: > > > On Sat, Apr 01, 2017 at 08:50:37AM -0400, Ronald S. Bultje wrote: > > > Hi, > > > > > > On Sat, Apr 1, 2017 at 6:15 AM, Michael Niedermayer > > > > > wr

Re: [FFmpeg-devel] [PATCH] frame_thread_encoder: make task indexing deterministic.

2017-04-01 Thread Ronald S. Bultje
Hi, On Sat, Apr 1, 2017 at 5:44 PM, Michael Niedermayer wrote: > On Sat, Apr 01, 2017 at 08:50:37AM -0400, Ronald S. Bultje wrote: > > Hi, > > > > On Sat, Apr 1, 2017 at 6:15 AM, Michael Niedermayer > > > wrote: > > [.] > > > > > > about the patch itself, the changes done to indexing seem not t

Re: [FFmpeg-devel] [PATCH] frame_thread_encoder: make task indexing deterministic.

2017-04-01 Thread Michael Niedermayer
On Sat, Apr 01, 2017 at 08:50:37AM -0400, Ronald S. Bultje wrote: > Hi, > > On Sat, Apr 1, 2017 at 6:15 AM, Michael Niedermayer > wrote: > [.] > > > > about the patch itself, the changes done to indexing seem not to > > change anything, it makes it possible for the variables to overflow > > thoug

Re: [FFmpeg-devel] [PATCH] frame_thread_encoder: make task indexing deterministic.

2017-04-01 Thread Ronald S. Bultje
Hi, On Sat, Apr 1, 2017 at 6:15 AM, Michael Niedermayer wrote: [.] > > about the patch itself, the changes done to indexing seem not to > change anything, it makes it possible for the variables to overflow > though. > That's intentional, they're both unsigned and the one is guaranteed to be larg

Re: [FFmpeg-devel] [PATCH] frame_thread_encoder: make task indexing deterministic.

2017-04-01 Thread Michael Niedermayer
On Fri, Mar 31, 2017 at 10:20:43AM -0400, Ronald S. Bultje wrote: > Fixes tsan warnings in fate-utvideoenc. Example warning from > utvideoenc_rgb_left: > > WARNING: ThreadSanitizer: data race (pid=19929) > Read of size 8 at 0x7d840001cf18 by main thread: > #0 ff_thread_video_encode_frame src