Re: [FFmpeg-devel] [PATCH] frame: Simplify the video allocation

2018-09-11 Thread Maxym Dmytrychenko
On Tue, Sep 11, 2018 at 6:43 PM James Almer wrote: > On 9/3/2018 6:03 AM, Maxym Dmytrychenko wrote: > > On Mon, Sep 3, 2018 at 10:17 AM Michael Niedermayer > > > wrote: > > > >> On Sun, Sep 02, 2018 at 09:34:23PM -0300, James Almer wrote: > >>> From: Luca Barbato > >>> > >>> Merged-by: James Al

Re: [FFmpeg-devel] [PATCH] frame: Simplify the video allocation

2018-09-11 Thread James Almer
On 9/3/2018 6:03 AM, Maxym Dmytrychenko wrote: > On Mon, Sep 3, 2018 at 10:17 AM Michael Niedermayer > wrote: > >> On Sun, Sep 02, 2018 at 09:34:23PM -0300, James Almer wrote: >>> From: Luca Barbato >>> >>> Merged-by: James Almer >>> --- >>> This is the next merge in the queue. It's a critical

Re: [FFmpeg-devel] [PATCH] frame: Simplify the video allocation

2018-09-09 Thread Michael Niedermayer
On Thu, Sep 06, 2018 at 08:04:02PM -0300, James Almer wrote: > On 9/6/2018 7:26 PM, Michael Niedermayer wrote: > > On Thu, Sep 06, 2018 at 01:10:31PM -0300, James Almer wrote: > >> On 9/4/2018 5:09 PM, Michael Niedermayer wrote: > >>> On Mon, Sep 03, 2018 at 10:29:13AM -0300, James Almer wrote: > >

Re: [FFmpeg-devel] [PATCH] frame: Simplify the video allocation

2018-09-06 Thread James Almer
On 9/6/2018 7:26 PM, Michael Niedermayer wrote: > On Thu, Sep 06, 2018 at 01:10:31PM -0300, James Almer wrote: >> On 9/4/2018 5:09 PM, Michael Niedermayer wrote: >>> On Mon, Sep 03, 2018 at 10:29:13AM -0300, James Almer wrote: On 9/3/2018 5:17 AM, Michael Niedermayer wrote: > On Sun, Sep 0

Re: [FFmpeg-devel] [PATCH] frame: Simplify the video allocation

2018-09-06 Thread Michael Niedermayer
On Thu, Sep 06, 2018 at 01:10:31PM -0300, James Almer wrote: > On 9/4/2018 5:09 PM, Michael Niedermayer wrote: > > On Mon, Sep 03, 2018 at 10:29:13AM -0300, James Almer wrote: > >> On 9/3/2018 5:17 AM, Michael Niedermayer wrote: > >>> On Sun, Sep 02, 2018 at 09:34:23PM -0300, James Almer wrote: > >

Re: [FFmpeg-devel] [PATCH] frame: Simplify the video allocation

2018-09-06 Thread James Almer
On 9/4/2018 5:09 PM, Michael Niedermayer wrote: > On Mon, Sep 03, 2018 at 10:29:13AM -0300, James Almer wrote: >> On 9/3/2018 5:17 AM, Michael Niedermayer wrote: >>> On Sun, Sep 02, 2018 at 09:34:23PM -0300, James Almer wrote: From: Luca Barbato Merged-by: James Almer ---

Re: [FFmpeg-devel] [PATCH] frame: Simplify the video allocation

2018-09-04 Thread Michael Niedermayer
On Mon, Sep 03, 2018 at 10:29:13AM -0300, James Almer wrote: > On 9/3/2018 5:17 AM, Michael Niedermayer wrote: > > On Sun, Sep 02, 2018 at 09:34:23PM -0300, James Almer wrote: > >> From: Luca Barbato > >> > >> Merged-by: James Almer > >> --- > >> This is the next merge in the queue. It's a critic

Re: [FFmpeg-devel] [PATCH] frame: Simplify the video allocation

2018-09-03 Thread James Almer
On 9/3/2018 11:56 AM, James Darnley wrote: > On 2018-09-03 15:29, James Almer wrote: >> pass 32 - 1 to both av_image_fill_pointers() calls directly? > > Please do not add a magic number where nobody will find it. Use one of > the 3 already existing methods for knowing the alignment necessary for

Re: [FFmpeg-devel] [PATCH] frame: Simplify the video allocation

2018-09-03 Thread James Darnley
On 2018-09-03 15:29, James Almer wrote: > pass 32 - 1 to both av_image_fill_pointers() calls directly? Please do not add a magic number where nobody will find it. Use one of the 3 already existing methods for knowing the alignment necessary for assembly. If this is unrelated, my apologies.

Re: [FFmpeg-devel] [PATCH] frame: Simplify the video allocation

2018-09-03 Thread James Almer
On 9/3/2018 5:17 AM, Michael Niedermayer wrote: > On Sun, Sep 02, 2018 at 09:34:23PM -0300, James Almer wrote: >> From: Luca Barbato >> >> Merged-by: James Almer >> --- >> This is the next merge in the queue. It's a critical part of the AVFrame API, >> so even if FATE passes I'd rather have other

Re: [FFmpeg-devel] [PATCH] frame: Simplify the video allocation

2018-09-03 Thread Maxym Dmytrychenko
On Mon, Sep 3, 2018 at 10:17 AM Michael Niedermayer wrote: > On Sun, Sep 02, 2018 at 09:34:23PM -0300, James Almer wrote: > > From: Luca Barbato > > > > Merged-by: James Almer > > --- > > This is the next merge in the queue. It's a critical part of the AVFrame > API, > > so even if FATE passes

Re: [FFmpeg-devel] [PATCH] frame: Simplify the video allocation

2018-09-03 Thread Michael Niedermayer
On Sun, Sep 02, 2018 at 09:34:23PM -0300, James Almer wrote: > From: Luca Barbato > > Merged-by: James Almer > --- > This is the next merge in the queue. It's a critical part of the AVFrame API, > so even if FATE passes I'd rather have others look at it and test in case > something breaks. > >