Re: [FFmpeg-devel] [PATCH] fix memory leak in qsvenc.c

2020-08-21 Thread Alex Pokotilo
> Seems reasonable, any special reason to reorder av_freep(&sync)? I want to combine "bs" and it's children structures disposal in the same order as in ff_qsv_encode where we have #if QSV_VERSION_ATLEAST(1, 26) if (avctx->codec_id == AV_CODEC_ID_H264) { enc_buf = bs->ExtParam

Re: [FFmpeg-devel] [PATCH] fix memory leak in qsvenc.c

2020-08-20 Thread Xiang, Haihao
Thanks for fixing the memory leak in qsv, it looks good to me. Regards Haihao > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-deve

Re: [FFmpeg-devel] [PATCH] fix memory leak in qsvenc.c

2020-08-16 Thread Alex Pokotilo
> Seems reasonable, any special reason to reorder av_freep(&sync)? I want to combine "bs" and it's children structures disposal in the same order as in ff_qsv_encode where we have #if QSV_VERSION_ATLEAST(1, 26) if (avctx->codec_id == AV_CODEC_ID_H264) { enc_buf = bs->ExtParam

Re: [FFmpeg-devel] [PATCH] fix memory leak in qsvenc.c

2020-08-14 Thread Linjie Fu
On Thu, Aug 13, 2020 at 10:15 AM Alex Pokotilo wrote: > > > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with

Re: [FFmpeg-devel] [PATCH] fix memory leak in qsvenc.c

2020-08-13 Thread Max Dmitrichenko
make sense. regards Max On Thu, Aug 13, 2020 at 4:15 AM Alex Pokotilo wrote: > > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel