Re: [FFmpeg-devel] [PATCH] ffserver_config: check for INT_MIN before doing FFABS

2015-10-13 Thread Ganesh Ajjanagadde
On Tue, Oct 13, 2015 at 3:45 PM, Michael Niedermayer wrote: > On Fri, Oct 09, 2015 at 11:31:22AM -0400, Ganesh Ajjanagadde wrote: >> FFABS(INT_MIN) is not safe. Alternative of using FFNABS is not as >> readable. >> >> Signed-off-by: Ganesh Ajjanagadde >> --- >> ffserver_config.c | 2 +- >> 1 fil

Re: [FFmpeg-devel] [PATCH] ffserver_config: check for INT_MIN before doing FFABS

2015-10-13 Thread Michael Niedermayer
On Fri, Oct 09, 2015 at 11:31:22AM -0400, Ganesh Ajjanagadde wrote: > FFABS(INT_MIN) is not safe. Alternative of using FFNABS is not as > readable. > > Signed-off-by: Ganesh Ajjanagadde > --- > ffserver_config.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) LGTM thanks [...] -- Mic

Re: [FFmpeg-devel] [PATCH] ffserver_config: check for INT_MIN before doing FFABS

2015-10-12 Thread Ganesh Ajjanagadde
On Fri, Oct 9, 2015 at 11:31 AM, Ganesh Ajjanagadde wrote: > FFABS(INT_MIN) is not safe. Alternative of using FFNABS is not as > readable. > > Signed-off-by: Ganesh Ajjanagadde > --- > ffserver_config.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ffserver_config.c b/