Re: [FFmpeg-devel] [PATCH] ffmpeg: set user-set rotation for encoded streams too

2022-05-17 Thread Jan Ekström
On Sun, May 15, 2022 at 3:21 PM Jan Ekström wrote: > > On Sun, May 15, 2022 at 2:58 PM Gyan Doshi wrote: > > > > > > > > On 2022-05-15 04:29 pm, Jan Ekström wrote: > > > On Thu, May 12, 2022 at 11:19 AM Anton Khirnov wrote: > > >> Quoting Gyan Doshi (2022-05-12 09:01:31) > > >>> A substitute opt

Re: [FFmpeg-devel] [PATCH] ffmpeg: set user-set rotation for encoded streams too

2022-05-15 Thread Jan Ekström
On Sun, May 15, 2022 at 2:58 PM Gyan Doshi wrote: > > > > On 2022-05-15 04:29 pm, Jan Ekström wrote: > > On Thu, May 12, 2022 at 11:19 AM Anton Khirnov wrote: > >> Quoting Gyan Doshi (2022-05-12 09:01:31) > >>> A substitute option for metadata rotate would accept a single rotation > >>> value. >

Re: [FFmpeg-devel] [PATCH] ffmpeg: set user-set rotation for encoded streams too

2022-05-15 Thread Gyan Doshi
On 2022-05-15 04:29 pm, Jan Ekström wrote: On Thu, May 12, 2022 at 11:19 AM Anton Khirnov wrote: Quoting Gyan Doshi (2022-05-12 09:01:31) A substitute option for metadata rotate would accept a single rotation value. If adding an option for matrix, we should allow flips too. I see no reason

Re: [FFmpeg-devel] [PATCH] ffmpeg: set user-set rotation for encoded streams too

2022-05-15 Thread Jan Ekström
On Thu, May 12, 2022 at 11:19 AM Anton Khirnov wrote: > > Quoting Gyan Doshi (2022-05-12 09:01:31) > > A substitute option for metadata rotate would accept a single rotation > > value. > > If adding an option for matrix, we should allow flips too. > > I see no reason not to have both. You can have

Re: [FFmpeg-devel] [PATCH] ffmpeg: set user-set rotation for encoded streams too

2022-05-12 Thread Anton Khirnov
Quoting Gyan Doshi (2022-05-12 09:01:31) > A substitute option for metadata rotate would accept a single rotation > value. > If adding an option for matrix, we should allow flips too. I see no reason not to have both. You can have a simple option for just the rotation and an advanced option for s

Re: [FFmpeg-devel] [PATCH] ffmpeg: set user-set rotation for encoded streams too

2022-05-12 Thread Gyan Doshi
On 2022-05-12 10:55 am, Anton Khirnov wrote: Quoting Gyan Doshi (2022-05-11 21:15:15) On 2022-05-12 12:19 am, Anton Khirnov wrote: Quoting Gyan Doshi (2022-05-11 14:18:49) On 2022-05-11 05:26 pm, Anton Khirnov wrote: Quoting Gyan Doshi (2022-05-10 13:40:54) So far, -metadata:s:v rotate w

Re: [FFmpeg-devel] [PATCH] ffmpeg: set user-set rotation for encoded streams too

2022-05-11 Thread Anton Khirnov
Quoting Gyan Doshi (2022-05-11 21:15:15) > > > On 2022-05-12 12:19 am, Anton Khirnov wrote: > > Quoting Gyan Doshi (2022-05-11 14:18:49) > >> > >> On 2022-05-11 05:26 pm, Anton Khirnov wrote: > >>> Quoting Gyan Doshi (2022-05-10 13:40:54) > So far, -metadata:s:v rotate would only be applied

Re: [FFmpeg-devel] [PATCH] ffmpeg: set user-set rotation for encoded streams too

2022-05-11 Thread Gyan Doshi
On 2022-05-12 12:19 am, Anton Khirnov wrote: Quoting Gyan Doshi (2022-05-11 14:18:49) On 2022-05-11 05:26 pm, Anton Khirnov wrote: Quoting Gyan Doshi (2022-05-10 13:40:54) So far, -metadata:s:v rotate would only be applied to streamcopied video streams. Using -metadata for this functional

Re: [FFmpeg-devel] [PATCH] ffmpeg: set user-set rotation for encoded streams too

2022-05-11 Thread Anton Khirnov
Quoting Gyan Doshi (2022-05-11 14:18:49) > > > On 2022-05-11 05:26 pm, Anton Khirnov wrote: > > Quoting Gyan Doshi (2022-05-10 13:40:54) > >> So far, -metadata:s:v rotate would only be applied to streamcopied > >> video streams. > > Using -metadata for this functionality is a hack that should be

Re: [FFmpeg-devel] [PATCH] ffmpeg: set user-set rotation for encoded streams too

2022-05-11 Thread Anton Khirnov
Quoting Gyan Doshi (2022-05-11 18:30:41) > > > On 2022-05-10 05:10 pm, Gyan Doshi wrote: > > So far, -metadata:s:v rotate would only be applied to streamcopied > > video streams. > > Plan to push tomorrow. WTF? This is not how development works. I had an objection to your patch, it was not res

Re: [FFmpeg-devel] [PATCH] ffmpeg: set user-set rotation for encoded streams too

2022-05-11 Thread Gyan Doshi
On 2022-05-10 05:10 pm, Gyan Doshi wrote: So far, -metadata:s:v rotate would only be applied to streamcopied video streams. Plan to push tomorrow. Gyan --- fftools/ffmpeg.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index a85ed18b08..

Re: [FFmpeg-devel] [PATCH] ffmpeg: set user-set rotation for encoded streams too

2022-05-11 Thread Gyan Doshi
On 2022-05-11 05:26 pm, Anton Khirnov wrote: Quoting Gyan Doshi (2022-05-10 13:40:54) So far, -metadata:s:v rotate would only be applied to streamcopied video streams. Using -metadata for this functionality is a hack that should be removed, not extended. When there's a replacement for CLI

Re: [FFmpeg-devel] [PATCH] ffmpeg: set user-set rotation for encoded streams too

2022-05-11 Thread Anton Khirnov
Quoting Gyan Doshi (2022-05-10 13:40:54) > So far, -metadata:s:v rotate would only be applied to streamcopied > video streams. Using -metadata for this functionality is a hack that should be removed, not extended. -- Anton Khirnov ___ ffmpeg-devel mail