Re: [FFmpeg-devel] [PATCH] examples/vaapi_enc: Add a VAAPI encoding example.

2017-07-31 Thread Mark Thompson
On 31/07/17 04:10, Jun Zhao wrote: > On 2017/7/30 8:07, Mark Thompson wrote: >> On 28/07/17 07:01, Jun Zhao wrote: >>> From d5414b451012b3a0169740a26f452785eb44cce5 Mon Sep 17 00:00:00 2001 >>> From: Jun Zhao >>> Date: Fri, 28 Jul 2017 01:39:27 -0400 >>> Subject: [PATCH] examples/vaapi_enc: Add a

Re: [FFmpeg-devel] [PATCH] examples/vaapi_enc: Add a VAAPI encoding example.

2017-07-30 Thread Jun Zhao
On 2017/7/30 8:07, Mark Thompson wrote: > On 28/07/17 07:01, Jun Zhao wrote: >> From d5414b451012b3a0169740a26f452785eb44cce5 Mon Sep 17 00:00:00 2001 >> From: Jun Zhao >> Date: Fri, 28 Jul 2017 01:39:27 -0400 >> Subject: [PATCH] examples/vaapi_enc: Add a VAAPI encoding example. >> >> Add a VAAP

Re: [FFmpeg-devel] [PATCH] examples/vaapi_enc: Add a VAAPI encoding example.

2017-07-30 Thread Jun Zhao
On 2017/7/30 18:45, Moritz Barsnick wrote: > On Fri, Jul 28, 2017 at 14:01:37 +0800, Jun Zhao wrote: > > It doesn't really matter much functionally, but I consider it good > style to report errors properly, especially in an example which will be > used by othe> >> +fin = fopen(input_file, "

Re: [FFmpeg-devel] [PATCH] examples/vaapi_enc: Add a VAAPI encoding example.

2017-07-30 Thread Moritz Barsnick
On Fri, Jul 28, 2017 at 14:01:37 +0800, Jun Zhao wrote: It doesn't really matter much functionally, but I consider it good style to report errors properly, especially in an example which will be used by others: > +fin = fopen(input_file, "r"); > +fout = fopen(output_file, "w+b"); > +i

Re: [FFmpeg-devel] [PATCH] examples/vaapi_enc: Add a VAAPI encoding example.

2017-07-29 Thread Mark Thompson
On 28/07/17 07:01, Jun Zhao wrote: > From d5414b451012b3a0169740a26f452785eb44cce5 Mon Sep 17 00:00:00 2001 > From: Jun Zhao > Date: Fri, 28 Jul 2017 01:39:27 -0400 > Subject: [PATCH] examples/vaapi_enc: Add a VAAPI encoding example. > > Add a VAAPI encoding example. > > Use hwupload loading the