Re: [FFmpeg-devel] [PATCH] diracdsp: Make x86 files/functions names consistent

2016-02-05 Thread Timothy Gu
On Tue, Feb 2, 2016 at 6:20 PM Timothy Gu wrote: > > > > diracdsp_init.o should be part of OBJS, not YASM-OBJS. > > Done. > > > > > While you're at it you could also change dirac_dwt in a similar > > fashion. > > And done. > 17:42 < jamrial> Timothy_Gu: yeah, seems ok. you'll have to rebase the d

Re: [FFmpeg-devel] [PATCH] diracdsp: Make x86 files/functions names consistent

2016-02-02 Thread Timothy Gu
On Tue, Feb 02, 2016 at 01:54:10AM -0300, James Almer wrote: > > diff --git a/libavcodec/x86/Makefile b/libavcodec/x86/Makefile > > index ce06b90..301b39b 100644 > > --- a/libavcodec/x86/Makefile > > +++ b/libavcodec/x86/Makefile > > @@ -133,7 +133,7 @@ YASM-OBJS-$(CONFIG_ADPCM_G722_ENCODER) += x86

Re: [FFmpeg-devel] [PATCH] diracdsp: Make x86 files/functions names consistent

2016-02-02 Thread Timothy Gu
On Tue, Feb 02, 2016 at 01:54:10AM -0300, James Almer wrote: > > diracdsp_init.o should be part of OBJS, not YASM-OBJS. There are some yasm function wrappers in that file that I'll need to wrap HAVE_YASM in, which is why I didn't push it into OBJS at first. > > While you're at it you could also

Re: [FFmpeg-devel] [PATCH] diracdsp: Make x86 files/functions names consistent

2016-02-01 Thread James Almer
On 2/2/2016 1:50 AM, Timothy Gu wrote: > --- > libavcodec/diracdsp.c | 5 +++-- > libavcodec/x86/Makefile| 2 +- > libavcodec/x86/{diracdsp_yasm.asm => diracdsp.asm} | 0 > libavcodec/x86/{diracdsp_mmx.h => diracdsp.h} | 2 +- > libavco