Re: [FFmpeg-devel] [PATCH] configure: add pkg-config support for libx264

2014-10-17 Thread Michael Niedermayer
On Fri, Oct 17, 2014 at 11:48:12PM +, Carl Eugen Hoyos wrote: > Benoit Fouet free.fr> writes: > > > +enabled libx264 && { { check_pkg_config x264 "stdint.h x264.h" > > x264_encoder_encode && > > + require_pkg_config x264 "stdint.h > > x264.h" x264_e

Re: [FFmpeg-devel] [PATCH] configure: add pkg-config support for libx264

2014-10-17 Thread Carl Eugen Hoyos
James Almer gmail.com> writes: > > You could add a line to the Changelog "pkg-config is now > > preferred over --extra-*flags for x264 detection." > A line saying something like "x264 may now also > be detected with pkg-config" is enough. I disagree (this would be the change that I originall

Re: [FFmpeg-devel] [PATCH] configure: add pkg-config support for libx264

2014-10-17 Thread James Almer
On 17/10/14 8:49 PM, Carl Eugen Hoyos wrote: > Benoit Fouet free.fr> writes: > >> +enabled libx264 && { { check_pkg_config x264 > > I forgot: > You could add a line to the Changelog "pkg-config is now > preferred over --extra-*flags for x264 detection." No need to mention it's prefer

Re: [FFmpeg-devel] [PATCH] configure: add pkg-config support for libx264

2014-10-17 Thread Carl Eugen Hoyos
Benoit Fouet free.fr> writes: > +enabled libx264 && { { check_pkg_config x264 I forgot: You could add a line to the Changelog "pkg-config is now preferred over --extra-*flags for x264 detection." Carl Eugen ___ ffmpeg-devel mailing list ff

Re: [FFmpeg-devel] [PATCH] configure: add pkg-config support for libx264

2014-10-17 Thread Carl Eugen Hoyos
Benoit Fouet free.fr> writes: > +enabled libx264 && { { check_pkg_config x264 "stdint.h x264.h" > x264_encoder_encode && > + require_pkg_config x264 "stdint.h > x264.h" x264_encoder_encode; } || > + { require libx264 x264.h