Re: [FFmpeg-devel] [PATCH] clear s->error in avio_read

2017-03-25 Thread wm4
On Fri, 24 Mar 2017 10:47:53 -0700 Fredrik Hubinette wrote: > On Fri, Mar 24, 2017 at 12:47 AM, wm4 wrote: > > > On Mon, 20 Mar 2017 14:39:07 -0700 > > Fredrik Hubinette wrote: > > > > > It looks like the value in s->error also comes from an earlier call to > > > avio_read(). > > > ogg_read_

Re: [FFmpeg-devel] [PATCH] clear s->error in avio_read

2017-03-24 Thread Fredrik Hubinette
On Fri, Mar 24, 2017 at 12:47 AM, wm4 wrote: > On Mon, 20 Mar 2017 14:39:07 -0700 > Fredrik Hubinette wrote: > > > It looks like the value in s->error also comes from an earlier call to > > avio_read(). > > ogg_read_page tries to read 4439 bytes from the file. It has 524 bytes > > already buffer

Re: [FFmpeg-devel] [PATCH] clear s->error in avio_read

2017-03-24 Thread wm4
On Mon, 20 Mar 2017 14:39:07 -0700 Fredrik Hubinette wrote: > It looks like the value in s->error also comes from an earlier call to > avio_read(). > ogg_read_page tries to read 4439 bytes from the file. It has 524 bytes > already buffered. > fill_buffer() fails with an EIO, but because of the bu

Re: [FFmpeg-devel] [PATCH] clear s->error in avio_read

2017-03-23 Thread Michael Niedermayer
On Mon, Mar 20, 2017 at 02:49:18PM -0700, Fredrik Hubinette wrote: > Hopefully valid patch attached. > > > On Mon, Mar 20, 2017 at 2:39 PM, Fredrik Hubinette wrote: > > > It looks like the value in s->error also comes from an earlier call to > > avio_read(). > > ogg_read_page tries to read 4439

Re: [FFmpeg-devel] [PATCH] clear s->error in avio_read

2017-03-22 Thread Fredrik Hubinette
ping? On Mon, Mar 20, 2017 at 2:49 PM, Fredrik Hubinette wrote: > Hopefully valid patch attached. > > > On Mon, Mar 20, 2017 at 2:39 PM, Fredrik Hubinette > wrote: > >> It looks like the value in s->error also comes from an earlier call to >> avio_read(). >> ogg_read_page tries to read 4439 by

Re: [FFmpeg-devel] [PATCH] clear s->error in avio_read

2017-03-20 Thread Fredrik Hubinette
Hopefully valid patch attached. On Mon, Mar 20, 2017 at 2:39 PM, Fredrik Hubinette wrote: > It looks like the value in s->error also comes from an earlier call to > avio_read(). > ogg_read_page tries to read 4439 bytes from the file. It has 524 bytes > already buffered. > fill_buffer() fails wi

Re: [FFmpeg-devel] [PATCH] clear s->error in avio_read

2017-03-20 Thread Fredrik Hubinette
It looks like the value in s->error also comes from an earlier call to avio_read(). ogg_read_page tries to read 4439 bytes from the file. It has 524 bytes already buffered. fill_buffer() fails with an EIO, but because of the buffered bytes, avio_read() returns 524 and leaves the EIO in s->error.

Re: [FFmpeg-devel] [PATCH] clear s->error in avio_read

2017-03-20 Thread Fredrik Hubinette
On Mon, Mar 20, 2017 at 1:35 PM, Michael Niedermayer wrote: > On Mon, Mar 20, 2017 at 10:21:08AM -0700, Fredrik Hubinette wrote: > > In some cases (when parsing OGG) non-fatal errors can happen, which > > will cause s->error to be set. In most cases, this is not a problem > beucase > > s->error i

Re: [FFmpeg-devel] [PATCH] clear s->error in avio_read

2017-03-20 Thread Michael Niedermayer
On Mon, Mar 20, 2017 at 10:21:08AM -0700, Fredrik Hubinette wrote: > In some cases (when parsing OGG) non-fatal errors can happen, which > will cause s->error to be set. In most cases, this is not a problem beucase > s->error is not checked unless an actual error has occurred. However, > when avio