Re: [FFmpeg-devel] [PATCH] avutil/libm: correct isnan, isinf compat hacks

2015-11-17 Thread Ganesh Ajjanagadde
On Mon, Nov 16, 2015 at 7:50 AM, Ganesh Ajjanagadde wrote: > On Mon, Nov 16, 2015 at 6:55 AM, Michael Niedermayer > wrote: >> On Sat, Nov 14, 2015 at 08:05:59PM -0500, Ganesh Ajjanagadde wrote: >>> isnan and isinf are actually macros as per the standard. In particular, >>> the existing implementa

Re: [FFmpeg-devel] [PATCH] avutil/libm: correct isnan, isinf compat hacks

2015-11-16 Thread Ganesh Ajjanagadde
On Mon, Nov 16, 2015 at 6:55 AM, Michael Niedermayer wrote: > On Sat, Nov 14, 2015 at 08:05:59PM -0500, Ganesh Ajjanagadde wrote: >> isnan and isinf are actually macros as per the standard. In particular, >> the existing implementation has incorrect signature. Furthermore, this >> results in undef

Re: [FFmpeg-devel] [PATCH] avutil/libm: correct isnan, isinf compat hacks

2015-11-16 Thread Michael Niedermayer
On Sat, Nov 14, 2015 at 08:05:59PM -0500, Ganesh Ajjanagadde wrote: > isnan and isinf are actually macros as per the standard. In particular, > the existing implementation has incorrect signature. Furthermore, this > results in undefined behavior for e.g double values outside float range > as per t