Re: [FFmpeg-devel] [PATCH] avutil/common: Add FFNABS()

2015-09-02 Thread Michael Niedermayer
On Wed, Sep 02, 2015 at 05:33:04PM -0700, Ganesh Ajjanagadde wrote: > On Wed, Sep 2, 2015 at 5:17 PM, Michael Niedermayer wrote: > > From: Michael Niedermayer > > > > This function avoids the undefined corner cases which affects other absolute > > value functions and macros > > LGTM, except for

Re: [FFmpeg-devel] [PATCH] avutil/common: Add FFNABS()

2015-09-02 Thread Ganesh Ajjanagadde
On Wed, Sep 2, 2015 at 5:17 PM, Michael Niedermayer wrote: > From: Michael Niedermayer > > This function avoids the undefined corner cases which affects other absolute > value functions and macros LGTM, except for the comment/commit message. This does not avoid all weird cases, see e.g https://s