Re: [FFmpeg-devel] [PATCH] avio_read data loss with multiple calls to fill_buffer

2017-05-19 Thread Rob Meyers
I can confirm the current source tree has resolved our issue. On Fri, May 19, 2017 at 12:16 PM Michael Niedermayer wrote: > On Fri, May 19, 2017 at 08:28:23PM +0200, Michael Niedermayer wrote: > > hi > > > > On Thu, May 18, 2017 at 10:58:39PM +, Rob Meyers wrote: > > > avio_read does multipl

Re: [FFmpeg-devel] [PATCH] avio_read data loss with multiple calls to fill_buffer

2017-05-19 Thread Michael Niedermayer
On Fri, May 19, 2017 at 08:28:23PM +0200, Michael Niedermayer wrote: > hi > > On Thu, May 18, 2017 at 10:58:39PM +, Rob Meyers wrote: > > avio_read does multiple calls to fill_buffer(). Adjusting things in > > fill_buffer was frowned upon; how would you suggest I approach this? > > Its not fr

Re: [FFmpeg-devel] [PATCH] avio_read data loss with multiple calls to fill_buffer

2017-05-19 Thread Michael Niedermayer
hi On Thu, May 18, 2017 at 10:58:39PM +, Rob Meyers wrote: > avio_read does multiple calls to fill_buffer(). Adjusting things in > fill_buffer was frowned upon; how would you suggest I approach this? Its not frowned upon to fix a bug in fill_buffer(), its frowned upon to make a random change

Re: [FFmpeg-devel] [PATCH] avio_read data loss with multiple calls to fill_buffer

2017-05-18 Thread Rob Meyers
avio_read does multiple calls to fill_buffer(). Adjusting things in fill_buffer was frowned upon; how would you suggest I approach this? The id3v2 seek doesn't come into play; the return from avio_read is the "full" read. The call I added in avio_read is only done when there was accumulated data,

Re: [FFmpeg-devel] [PATCH] avio_read data loss with multiple calls to fill_buffer

2017-05-18 Thread Michael Niedermayer
On Thu, May 18, 2017 at 01:12:49PM -0700, Rob Meyers wrote: > avio_read may make multiple calls to fill_buffer to accumulate bytes > to fulfill a request. fill_buffer will overwrite previously read data > if it is not prepped. Added a call to 'ffio_ensure_seekback' to adjust > the s->buffer to fill