Re: [FFmpeg-devel] [PATCH] avformat/webvttdec: improve WebVTT parsing

2025-07-18 Thread Michael Niedermayer
Hi Tomas On Fri, Jun 06, 2025 at 09:43:58PM +0200, Tomas Härdin wrote: > tis 2025-05-27 klockan 10:40 + skrev Marcos Del Sol via ffmpeg- > devel: > > A note on this change: I found some .vtt files while using yt-dlp > > that follow > > a draft version of the WebVTT standard (probably > > https

Re: [FFmpeg-devel] [PATCH] avformat/webvttdec: improve WebVTT parsing

2025-07-18 Thread Michael Niedermayer
Hi On Tue, May 27, 2025 at 12:28:11PM +0200, Marcos Del Sol Vives via ffmpeg-devel wrote: > The parser will now strictly check if WebVTT files start with the correct > "WEBVTT" marker. Before, files were not checked if they truly started > with it. > > It will also now ignore all non-cue blocks,

Re: [FFmpeg-devel] [PATCH] avformat/webvttdec: improve WebVTT parsing

2025-07-17 Thread Marcos Del Sol
Hello. Can someone with merging permission have a look at this please? This bug is still impacting me. Thanks, Marcos -Mensaje original- De: Marcos Para: ffmpeg-devel CC: Marcos Fecha: martes, 27 de mayo de 2025 12:40 CEST Asunto: Re: [PATCH] avformat/webvttdec: improve WebVTT parsing

Re: [FFmpeg-devel] [PATCH] avformat/webvttdec: improve WebVTT parsing

2025-06-18 Thread Tomas Härdin
fre 2025-06-13 klockan 13:03 + skrev Marcos Del Sol: > Tomas Härdin: > > tis 2025-06-10 klockan 11:42 + skrev Marcos Del Sol: > > > WebVTT is supposed to be an extensible format. > > > > The syntax says otherwise. Why the W3C feels the need to specify a > > particular imperative algorithm

Re: [FFmpeg-devel] [PATCH] avformat/webvttdec: improve WebVTT parsing

2025-06-13 Thread Marcos Del Sol
Tomas Härdin: > tis 2025-06-10 klockan 11:42 + skrev Marcos Del Sol: > > WebVTT is supposed to be an extensible format. > > The syntax says otherwise. Why the W3C feels the need to specify a > particular imperative algorithm for parsing I cannot know, but this is > not how RFCs are authored. It

Re: [FFmpeg-devel] [PATCH] avformat/webvttdec: improve WebVTT parsing

2025-06-10 Thread Marcos Del Sol
> WebVTT is supposed to be an extensible format. Limiting to a small set of > known values and silently aborting when anything new is introduced does > not seem like the best option to me. Web browsers do not stop rendering > pages when they see a new, unknown HTML tag or CSS option. About this, f

Re: [FFmpeg-devel] [PATCH] avformat/webvttdec: improve WebVTT parsing

2025-06-09 Thread Marcos Del Sol
> The linked file does not follow the syntax specified in section 4 of > the WebVTT standard. Therefore it is not WebVTT. The section 6.1 on file parsing, says explicitely that processing should be aborted if, and only if: - The file is too small (point 4) - The file does not start with "WEBVTT

Re: [FFmpeg-devel] [PATCH] avformat/webvttdec: improve WebVTT parsing

2025-06-09 Thread Tomas Härdin
fre 2025-06-06 klockan 22:22 +0200 skrev Marcos Del Sol Vives: > > > El 6 de junio de 2025 21:43:58 CEST, "Tomas Härdin" > escribió: > > > > Sounds like the demuxer correctly rejected some broken files > > > > The WebVTT standard does not call for a fatal error unless the magic > header does

Re: [FFmpeg-devel] [PATCH] avformat/webvttdec: improve WebVTT parsing

2025-06-06 Thread Marcos Del Sol Vives
El 6 de junio de 2025 21:43:58 CEST, "Tomas Härdin" escribió: > >Sounds like the demuxer correctly rejected some broken files > The WebVTT standard does not call for a fatal error unless the magic header does not match. The current implementation is not only non-compliant with the standard, b

Re: [FFmpeg-devel] [PATCH] avformat/webvttdec: improve WebVTT parsing

2025-06-06 Thread Tomas Härdin
tis 2025-05-27 klockan 10:40 + skrev Marcos Del Sol via ffmpeg- devel: > A note on this change: I found some .vtt files while using yt-dlp > that follow > a draft version of the WebVTT standard (probably > https://www.w3.org/2013/07/webvtt.html) that use "Region:" for > regions instead > of "RE

Re: [FFmpeg-devel] [PATCH] avformat/webvttdec: improve WebVTT parsing

2025-05-27 Thread Marcos Del Sol via ffmpeg-devel
A note on this change: I found some .vtt files while using yt-dlp that follow a draft version of the WebVTT standard (probably https://www.w3.org/2013/07/webvtt.html) that use "Region:" for regions instead of "REGION", and that was causing the conversion to .srt to fail completely. An example of t