Le primidi 21 vendémiaire, an CCXXVI, nablet developer a écrit :
> that's true - 90% of your comments are for original udp.c code I didn't
> touch.
When you are copy-pasting code, you are not only copy-pasting features,
you are also copy-pasting bugs and maintenance burden. When a bug is
found in
On 12-Oct-17 01:01, Derek Buitenhuis wrote:
Is it possible to deduplicate / share code with udp.c? It seems really iffy to
duplicate a large swath of code. For example, a bunch of my review comments may
also correspond to udp.c (in fact they may originate from udp.c).
that's true - 90% of your c
On 12-Oct-17 01:11, Derek Buitenhuis wrote:
So user options are overridden by URL params...?
exactly. at least in case of udp and few other protocols. it's
documented https://ffmpeg.org/ffmpeg-protocols.html#udp
The required syntax for an UDP URL is:
udp://hostname:port[?options]
options con
On 10/11/2017 12:08 PM, Nablet Developer wrote:
> sure, what do you suggest? use "libopensrt" or just "libsrt"? the second
> one wasn't recommended, because it introduces confusion with subtitle
> format library.
Probably the former, but I have no real strong opinion on changing it.
> it's docu
On 10/11/2017 4:57 AM, nablet developer wrote:
> you're absolutely right - this patch is based on udp.c (actually I
> initially copied udp.c and replaced bsd sockets to corresponding SRT
> calls, with some additional modifications).
Is it possible to deduplicate / share code with udp.c? It seems
Le nonidi 19 vendémiaire, an CCXXVI, Nablet Developer a écrit :
> protocol requires libsrt (https://github.com/Haivision/srt) to be
> installed
>
> Signed-off-by: Nablet Developer
> ---
> configure |5 +
> libavformat/Makefile|1 +
> libavformat/opensrt.c | 1105
> +
On 10/10/2017 22:47, Derek Buitenhuis wrote:
On 10/10/2017 7:29 AM, Nablet Developer wrote:
@@ -293,6 +293,7 @@ External library support:
--enable-opengl enable OpenGL rendering [no]
--enable-openssl enable openssl, needed for https support
Has this patch been run under valgrind, on Windows, and with stuff like ASAN,
etc.?
Some stuff here would even trigger compiler warnings normally.
compiled on Windows, but didn't run under valgrind or ASAN yet.
Also, how much of this stuff is duplicated from the udp.c and pals?
you're absolute
On 10/10/2017 7:29 AM, Nablet Developer wrote:
> @@ -293,6 +293,7 @@ External library support:
>--enable-opengl enable OpenGL rendering [no]
>--enable-openssl enable openssl, needed for https support
> if gnutls is not used [no]
> + --enable-ope
