Re: [FFmpeg-devel] [PATCH] avformat/mpegts: set data broadcast streams as such

2022-04-04 Thread Jan Ekström
On Mon, Apr 4, 2022 at 7:32 PM TADANO Tokumei wrote: > > Ah, the variables should be int. > > On 2022/04/05 1:16, TADANO Tokumei wrote: > > ... and, it is better to check broken packet. > > Yes. I guess I'll swap those for ints, although I like having the original unsigned sizes :) . I think alt

Re: [FFmpeg-devel] [PATCH] avformat/mpegts: set data broadcast streams as such

2022-04-04 Thread Jan Ekström
On Mon, Apr 4, 2022 at 7:04 PM TADANO Tokumei wrote: > > As I posted a patch on Apr. 3rd, you should use "desc_end" rather than "p_end" > for get16() or get8() to parse each descriptor. > Yes, I had noticed and planned to look into those patches, but did not have the time to do that yet. Also FY

Re: [FFmpeg-devel] [PATCH] avformat/mpegts: set data broadcast streams as such

2022-04-04 Thread TADANO Tokumei
Ah, the variables should be int. On 2022/04/05 1:16, TADANO Tokumei wrote: ... and, it is better to check broken packet. On 2022/04/05 1:04, TADANO Tokumei wrote: As I posted a patch on Apr. 3rd, you should use "desc_end" rather than "p_end" for get16() or get8() to parse each descriptor. On

Re: [FFmpeg-devel] [PATCH] avformat/mpegts: set data broadcast streams as such

2022-04-04 Thread TADANO Tokumei
... and, it is better to check broken packet. On 2022/04/05 1:04, TADANO Tokumei wrote: As I posted a patch on Apr. 3rd, you should use "desc_end" rather than "p_end" for get16() or get8() to parse each descriptor. On 2022/04/04 18:53, Jan Ekström wrote: From: Jan Ekström Additionally, they

Re: [FFmpeg-devel] [PATCH] avformat/mpegts: set data broadcast streams as such

2022-04-04 Thread TADANO Tokumei
As I posted a patch on Apr. 3rd, you should use "desc_end" rather than "p_end" for get16() or get8() to parse each descriptor. On 2022/04/04 18:53, Jan Ekström wrote: From: Jan Ekström Additionally, they should not be probed, as this is essentially various types of binary data. Signed-off-by:

Re: [FFmpeg-devel] [PATCH] avformat/mpegts: set data broadcast streams as such

2022-04-04 Thread Jan Ekström
On Mon, Apr 4, 2022 at 12:53 PM Jan Ekström wrote: > > From: Jan Ekström > > Additionally, they should not be probed, as this is essentially > various types of binary data. > > Signed-off-by: Jan Ekström > --- The test file referenced with this sort of signaling is available at: https://megumi