Re: [FFmpeg-devel] [PATCH] avformat/mp3dec: fix gapless audio support

2014-09-20 Thread Michael Niedermayer
On Sat, Sep 20, 2014 at 01:48:05PM +0200, wm4 wrote: > The code already had skipping of initial padding, but discarding > trailing frame padding was missing. > > This is somewhat questionable, because it will make the decoder discard > any data after the declared file size in the LAME header. But

Re: [FFmpeg-devel] [PATCH] avformat/mp3dec: fix gapless audio support

2014-09-20 Thread Michael Niedermayer
On Sat, Sep 20, 2014 at 11:10:19AM +0200, wm4 wrote: > The code already had skipping of initial padding, but discarding > trailing frame padding was missing. > > This is somewhat questionable, because it will make the decoder discard > any data after the declared file size in the LAME header. But