Re: [FFmpeg-devel] [PATCH] avformat/movenc: Remove dts delay from duration.

2021-01-18 Thread Josh Allmann
Hi Martin, On Fri, 15 Jan 2021 at 04:59, Martin Storsjö wrote: > > Hi Josh, > > On Tue, 22 Dec 2020, Josh Allmann wrote: > > > Thank you for taking the time to look into this! Tested with your > > alternative patch and it does seem to be an improvement. I was able to > > find a case where it didn

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Remove dts delay from duration.

2021-01-15 Thread Martin Storsjö
Hi Josh, On Tue, 22 Dec 2020, Josh Allmann wrote: Thank you for taking the time to look into this! Tested with your alternative patch and it does seem to be an improvement. I was able to find a case where it didn't seem to do the correct thing (described below), but this is not a regression; ma

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Remove dts delay from duration.

2020-12-22 Thread Josh Allmann
Hi Martin, On Sat, 19 Dec 2020 at 15:10, Martin Storsjö wrote: > > On Fri, 11 Dec 2020, Josh Allmann wrote: > > > On Fri, 11 Dec 2020 at 14:07, Martin Storsjö wrote: > >> > >> On Fri, 11 Dec 2020, Josh Allmann wrote: > >> > >> > A negative start_dts value (eg, delay from edit lists) typically yi

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Remove dts delay from duration.

2020-12-19 Thread Martin Storsjö
On Fri, 11 Dec 2020, Josh Allmann wrote: On Fri, 11 Dec 2020 at 14:07, Martin Storsjö wrote: On Fri, 11 Dec 2020, Josh Allmann wrote: > A negative start_dts value (eg, delay from edit lists) typically yields > a duration larger than end_pts. During edit list processing, the > delay is remove

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Remove dts delay from duration.

2020-12-14 Thread Martin Storsjö
Hi, On Fri, 11 Dec 2020, Josh Allmann wrote: On Fri, 11 Dec 2020 at 14:07, Martin Storsjö wrote: On Fri, 11 Dec 2020, Josh Allmann wrote: > A negative start_dts value (eg, delay from edit lists) typically yields > a duration larger than end_pts. During edit list processing, the > delay is r

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Remove dts delay from duration.

2020-12-11 Thread Josh Allmann
On Fri, 11 Dec 2020 at 14:07, Martin Storsjö wrote: > > On Fri, 11 Dec 2020, Josh Allmann wrote: > > > A negative start_dts value (eg, delay from edit lists) typically yields > > a duration larger than end_pts. During edit list processing, the > > delay is removed again, yielding the correct durat

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Remove dts delay from duration.

2020-12-11 Thread Martin Storsjö
On Fri, 11 Dec 2020, Josh Allmann wrote: A negative start_dts value (eg, delay from edit lists) typically yields a duration larger than end_pts. During edit list processing, the delay is removed again, yielding the correct duration within the elst. However, other duration-carrying atoms (tkhd,