Re: [FFmpeg-devel] [PATCH] avformat/movenc: Fix muxing EAC3 with delay_moov

2019-02-05 Thread Niki Bowe
On Tue, Feb 5, 2019 at 4:33 PM Niki Bowe wrote: > Hi Carl. > You are of course correct. > Attached replacement patch. > > > On Mon, Feb 4, 2019 at 6:24 PM Carl Eugen Hoyos > wrote: > >> 2019-02-05 3:11 GMT+01:00, Nikolas Bowe : >> >> > +if (mov->tracks[i].eac3_priv) >> > +av_

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Fix muxing EAC3 with delay_moov

2019-02-05 Thread Niki Bowe
Hi Carl. You are of course correct. Attached replacement patch. On Mon, Feb 4, 2019 at 6:24 PM Carl Eugen Hoyos wrote: > 2019-02-05 3:11 GMT+01:00, Nikolas Bowe : > > > +if (mov->tracks[i].eac3_priv) > > +av_freep(&mov->tracks[i].eac3_priv); > > I would have expected that th

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Fix muxing EAC3 with delay_moov

2019-02-04 Thread Carl Eugen Hoyos
2019-02-05 3:11 GMT+01:00, Nikolas Bowe : > +if (mov->tracks[i].eac3_priv) > +av_freep(&mov->tracks[i].eac3_priv); I would have expected that the if() is unneeded, no? Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org