Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: check the segment duration valid

2020-08-17 Thread Steven Liu
Nicolas George 于2020年8月17日周一 下午5:24写道: > > Steven Liu (12020-08-17): > > When hls muxer have beed support split_by_time flag add, the 8216 have > > not beed release, > > and there have some guys order this feature, for example me. > > And I saw lots of people are using this flag, so this maybe can

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: check the segment duration valid

2020-08-17 Thread Nicolas George
Steven Liu (12020-08-17): > As Zhili Zhao said, the problem is the user is using hls_time with too > short duration and want split not by keyframe. > I have been think about how to make the user know it don't support > short than 2 frames and with bframes, > but this is not the better way. > I thin

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: check the segment duration valid

2020-08-17 Thread Nicolas George
Steven Liu (12020-08-17): > When hls muxer have beed support split_by_time flag add, the 8216 have > not beed release, > and there have some guys order this feature, for example me. > And I saw lots of people are using this flag, so this maybe cannot be > removed now. > So I think give a warning me

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: check the segment duration valid

2020-08-17 Thread Steven Liu
Nicolas George 于2020年8月17日周一 下午4:06写道: > > Steven Liu (12020-08-17): > > Output a warning message if the target duration of the segment is negative. > > Suggest user increase the hls_time value, > > and modify the target duration to one packet duration, > > because there maybe have bframe and then

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: check the segment duration valid

2020-08-17 Thread Steven Liu
zhilizhao 于2020年8月17日周一 下午5:06写道: > > > > > On Aug 17, 2020, at 4:05 PM, Nicolas George wrote: > > > > Steven Liu (12020-08-17): > >> Output a warning message if the target duration of the segment is negative. > >> Suggest user increase the hls_time value, > >> and modify the target duration to o

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: check the segment duration valid

2020-08-17 Thread zhilizhao
> On Aug 17, 2020, at 4:05 PM, Nicolas George wrote: > > Steven Liu (12020-08-17): >> Output a warning message if the target duration of the segment is negative. >> Suggest user increase the hls_time value, >> and modify the target duration to one packet duration, >> because there maybe have bf

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: check the segment duration valid

2020-08-17 Thread Nicolas George
Steven Liu (12020-08-17): > Output a warning message if the target duration of the segment is negative. > Suggest user increase the hls_time value, > and modify the target duration to one packet duration, > because there maybe have bframe and then split not by keyframe, > and the segment is very ve

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: check the segment duration valid

2020-08-16 Thread zhilizhao
> On Aug 17, 2020, at 11:18 AM, Steven Liu wrote: > > zhilizhao mailto:quinkbl...@foxmail.com>> > 于2020年8月17日周一 上午11:15写道: >> >> >> >>> On Aug 17, 2020, at 11:02 AM, Steven Liu >> > wrote: >>> >>> zhilizhao mailto:quinkbl...@foxmail.com> >>>

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: check the segment duration valid

2020-08-16 Thread Steven Liu
zhilizhao 于2020年8月17日周一 上午11:15写道: > > > > > On Aug 17, 2020, at 11:02 AM, Steven Liu wrote: > > > > zhilizhao mailto:quinkbl...@foxmail.com>> > > 于2020年8月17日周一 上午10:54写道: > >> > >> Hi Steven, > >> > >>> On Aug 17, 2020, at 8:49 AM, Steven Liu >>> > wrote: > >>> > >

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: check the segment duration valid

2020-08-16 Thread zhilizhao
> On Aug 17, 2020, at 11:02 AM, Steven Liu wrote: > > zhilizhao mailto:quinkbl...@foxmail.com>> > 于2020年8月17日周一 上午10:54写道: >> >> Hi Steven, >> >>> On Aug 17, 2020, at 8:49 AM, Steven Liu >> > wrote: >>> >>> output a warning message if the target duration of the

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: check the segment duration valid

2020-08-16 Thread Steven Liu
zhilizhao 于2020年8月17日周一 上午10:54写道: > > Hi Steven, > > > On Aug 17, 2020, at 8:49 AM, Steven Liu wrote: > > > > output a warning message if the target duration of the segment. > > The sentence is incomplete. Ah ,yes, should "Output a warning message if the target duration of the segment is negativ

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: check the segment duration valid

2020-08-16 Thread zhilizhao
Hi Steven, > On Aug 17, 2020, at 8:49 AM, Steven Liu wrote: > > output a warning message if the target duration of the segment. The sentence is incomplete. > and modify the target duration to one packet duration, > because there maybe have bframe and then split not by keyframe, > and the segme