On Fri, 22 Dec 2023, Frank Plowman wrote:
Hi Martin,
Thanks for the review.
On 22/12/2023 12:15, Martin Storsjö wrote:
The change LGTM, but the wording here is slightly confusing IMO. The
problem isn't with using per se AVERROR, that's just a macro for generating
suitable integers, the issue
Hi Martin,
Thanks for the review.
On 22/12/2023 12:15, Martin Storsjö wrote:
The change LGTM, but the wording here is slightly confusing IMO. The
problem isn't with using per se AVERROR, that's just a macro for
generating suitable integers, the issue is more about the fact that
we're returnin
Hi Frank,
On Fri, 22 Dec 2023, Frank Plowman wrote:
The gcrypt definition of `bn_new` used to use `AVERROR`, however it is
called in `dh_generate_key` and `ff_dh_init` which return pointers. As a
result, compiling with gcrypt and the ffrtmpcrypt protocol resulted in an
int-conversion warning. G
