Re: [FFmpeg-devel] [PATCH] avformat/avienc: Store pal8 palette

2016-02-19 Thread Michael Niedermayer
On Fri, Feb 19, 2016 at 02:15:01PM +0100, Mats Peterson wrote: > On 02/19/2016 02:08 PM, Mats Peterson wrote: > >On 02/19/2016 02:05 PM, Mats Peterson wrote: > >>On 02/18/2016 11:07 PM, Mats Peterson wrote: > >>>On 02/18/2016 11:04 PM, Michael Niedermayer wrote: > On Thu, Feb 18, 2016 at 10:40:

Re: [FFmpeg-devel] [PATCH] avformat/avienc: Store pal8 palette

2016-02-19 Thread Mats Peterson
On 02/19/2016 03:46 PM, Michael Niedermayer wrote: applied thanks Great, Michael. Thanks. Mats ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avformat/avienc: Store pal8 palette

2016-02-19 Thread Michael Niedermayer
On Thu, Feb 18, 2016 at 10:39:38PM +0100, Moritz Barsnick wrote: > On Thu, Feb 18, 2016 at 21:14:55 +0100, Michael Niedermayer wrote: > > + * no zerp if a new packet was allocated and ppkt has to be freed > > "no zerp"? Cute. Probably "non-zero" fixed thx [...] -- Michael GnuPG fing

Re: [FFmpeg-devel] [PATCH] avformat/avienc: Store pal8 palette

2016-02-19 Thread Mats Peterson
On 02/19/2016 02:15 PM, Mats Peterson wrote: On 02/19/2016 02:08 PM, Mats Peterson wrote: On 02/19/2016 02:05 PM, Mats Peterson wrote: On 02/18/2016 11:07 PM, Mats Peterson wrote: On 02/18/2016 11:04 PM, Michael Niedermayer wrote: On Thu, Feb 18, 2016 at 10:40:42PM +0100, Mats Peterson wrote:

Re: [FFmpeg-devel] [PATCH] avformat/avienc: Store pal8 palette

2016-02-19 Thread Mats Peterson
On 02/19/2016 02:08 PM, Mats Peterson wrote: On 02/19/2016 02:05 PM, Mats Peterson wrote: On 02/18/2016 11:07 PM, Mats Peterson wrote: On 02/18/2016 11:04 PM, Michael Niedermayer wrote: On Thu, Feb 18, 2016 at 10:40:42PM +0100, Mats Peterson wrote: On 02/18/2016 10:27 PM, Mats Peterson wrote:

Re: [FFmpeg-devel] [PATCH] avformat/avienc: Store pal8 palette

2016-02-19 Thread Mats Peterson
On 02/19/2016 02:05 PM, Mats Peterson wrote: On 02/18/2016 11:07 PM, Mats Peterson wrote: On 02/18/2016 11:04 PM, Michael Niedermayer wrote: On Thu, Feb 18, 2016 at 10:40:42PM +0100, Mats Peterson wrote: On 02/18/2016 10:27 PM, Mats Peterson wrote: On 02/18/2016 09:14 PM, Michael Niedermayer

Re: [FFmpeg-devel] [PATCH] avformat/avienc: Store pal8 palette

2016-02-19 Thread Mats Peterson
On 02/18/2016 11:07 PM, Mats Peterson wrote: On 02/18/2016 11:04 PM, Michael Niedermayer wrote: On Thu, Feb 18, 2016 at 10:40:42PM +0100, Mats Peterson wrote: On 02/18/2016 10:27 PM, Mats Peterson wrote: On 02/18/2016 09:14 PM, Michael Niedermayer wrote: This can be made more efficient, but f

Re: [FFmpeg-devel] [PATCH] avformat/avienc: Store pal8 palette

2016-02-18 Thread Mats Peterson
On 02/18/2016 11:04 PM, Michael Niedermayer wrote: On Thu, Feb 18, 2016 at 10:40:42PM +0100, Mats Peterson wrote: On 02/18/2016 10:27 PM, Mats Peterson wrote: On 02/18/2016 09:14 PM, Michael Niedermayer wrote: This can be made more efficient, but first and the main goal of this change is to st

Re: [FFmpeg-devel] [PATCH] avformat/avienc: Store pal8 palette

2016-02-18 Thread Michael Niedermayer
On Thu, Feb 18, 2016 at 10:40:42PM +0100, Mats Peterson wrote: > On 02/18/2016 10:27 PM, Mats Peterson wrote: > >On 02/18/2016 09:14 PM, Michael Niedermayer wrote: > >>This can be made more efficient, but first and the main goal of this > >>change is to > >>store it at all > >Great, Michael. I'll t

Re: [FFmpeg-devel] [PATCH] avformat/avienc: Store pal8 palette

2016-02-18 Thread Mats Peterson
On 02/18/2016 10:53 PM, Mats Peterson wrote: FFplay plays these files fine, but Windows XP Media Player needs that palette after the BITMAPINFOHEADER. It doesn't seem to care about those 'xxpc' chunks. Interesting, since the Media Player ought to support everything in the AVI specs. That is Wind

Re: [FFmpeg-devel] [PATCH] avformat/avienc: Store pal8 palette

2016-02-18 Thread Mats Peterson
On 02/18/2016 10:40 PM, Mats Peterson wrote: On 02/18/2016 10:27 PM, Mats Peterson wrote: On 02/18/2016 09:14 PM, Michael Niedermayer wrote: This can be made more efficient, but first and the main goal of this change is to store it at all Great, Michael. I'll try it out. Mats I notice that

Re: [FFmpeg-devel] [PATCH] avformat/avienc: Store pal8 palette

2016-02-18 Thread Mats Peterson
On 02/18/2016 10:39 PM, Moritz Barsnick wrote: On Thu, Feb 18, 2016 at 21:14:55 +0100, Michael Niedermayer wrote: + * no zerp if a new packet was allocated and ppkt has to be freed "no zerp"? Cute. Probably "non-zero" That's a new term ;) ___

Re: [FFmpeg-devel] [PATCH] avformat/avienc: Store pal8 palette

2016-02-18 Thread Mats Peterson
On 02/18/2016 10:27 PM, Mats Peterson wrote: On 02/18/2016 09:14 PM, Michael Niedermayer wrote: This can be made more efficient, but first and the main goal of this change is to store it at all Great, Michael. I'll try it out. Mats I notice that the palette inclusion is only made by using '

Re: [FFmpeg-devel] [PATCH] avformat/avienc: Store pal8 palette

2016-02-18 Thread Moritz Barsnick
On Thu, Feb 18, 2016 at 21:14:55 +0100, Michael Niedermayer wrote: > + * no zerp if a new packet was allocated and ppkt has to be freed "no zerp"? Cute. Probably "non-zero" Moritz ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmp

Re: [FFmpeg-devel] [PATCH] avformat/avienc: Store pal8 palette

2016-02-18 Thread Mats Peterson
On 02/18/2016 09:14 PM, Michael Niedermayer wrote: This can be made more efficient, but first and the main goal of this change is to store it at all Great, Michael. I'll try it out. Mats ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://f