Re: [FFmpeg-devel] [PATCH] avformat/av1: Initialize padding in ff_isom_write_av1c

2019-04-08 Thread James Almer
On 4/8/2019 10:53 AM, Jeremy Dorfman via ffmpeg-devel wrote: > Judging by the code, I think flush_put_bits only pads out to a byte > boundary rather than the end of the buffer. By my read it will run the body > of the while loop 3 times in this case, for bit_left = 8, 16, 24, so only 3 > bytes are

Re: [FFmpeg-devel] [PATCH] avformat/av1: Initialize padding in ff_isom_write_av1c

2019-04-08 Thread Jeremy Dorfman via ffmpeg-devel
Judging by the code, I think flush_put_bits only pads out to a byte boundary rather than the end of the buffer. By my read it will run the body of the while loop 3 times in this case, for bit_left = 8, 16, 24, so only 3 bytes are filled in header. I'd expect this to only affect the actual output i

Re: [FFmpeg-devel] [PATCH] avformat/av1: Initialize padding in ff_isom_write_av1c

2019-04-08 Thread James Almer
On 4/8/2019 9:14 AM, Jeremy Dorfman via ffmpeg-devel wrote: > Otherwise, AV1 encodes with FFmpeg trigger use-of-uninitialized-value > warnings under MemorySanitizer, and the output buffer potentially > changes from run to run. > --- > libavformat/av1.c | 1 + > 1 file changed, 1 insertion(+) > >