Re: [FFmpeg-devel] [PATCH] avcodec: rewrite gif muxing and encoding

2018-12-12 Thread Nicolas George
Paul B Mahol (2018-12-12): > Demuxer only split file into small packets, no data is trimmed. > Encoder & muxer currently expect completely another format > where muxer writes stuff like disposal method which should > be really encoder job. > With this patch muxer only modifies delay between two pac

Re: [FFmpeg-devel] [PATCH] avcodec: rewrite gif muxing and encoding

2018-12-12 Thread Paul B Mahol
On 12/12/18, Nicolas George wrote: > Paul B Mahol (2018-12-12): >> It needs that because decoder & demuxer work that way. > > This answer do not say anything. Please elaborate enough as to be > convincing. And put it in the commit message. Demuxer only split file into small packets, no data is tr

Re: [FFmpeg-devel] [PATCH] avcodec: rewrite gif muxing and encoding

2018-12-12 Thread Nicolas George
Paul B Mahol (2018-12-12): > It needs that because decoder & demuxer work that way. This answer do not say anything. Please elaborate enough as to be convincing. And put it in the commit message. Regards, -- Nicolas George signature.asc Description: Digital signature ___

Re: [FFmpeg-devel] [PATCH] avcodec: rewrite gif muxing and encoding

2018-12-12 Thread Paul B Mahol
On 12/12/18, Nicolas George wrote: > Paul B Mahol (2018-12-11): >> Now "-c copy" works. >> Update FATE files. >> >> Signed-off-by: Paul B Mahol >> --- >> libavcodec/gif.c| 127 +++- >> libavformat/gif.c | 242 ++ >> tests/ref/fate/gifenc-

Re: [FFmpeg-devel] [PATCH] avcodec: rewrite gif muxing and encoding

2018-12-12 Thread Nicolas George
Paul B Mahol (2018-12-11): > Now "-c copy" works. > Update FATE files. > > Signed-off-by: Paul B Mahol > --- > libavcodec/gif.c| 127 +++- > libavformat/gif.c | 242 ++ > tests/ref/fate/gifenc-bgr4_byte | 346 -

Re: [FFmpeg-devel] [PATCH] avcodec: rewrite gif muxing and encoding

2018-12-12 Thread Paul B Mahol
On 12/11/18, Carl Eugen Hoyos wrote: > 2018-12-11 17:40 GMT+01:00, Paul B Mahol : >> On 12/11/18, Carl Eugen Hoyos wrote: >>> 2018-12-11 17:37 GMT+01:00, Paul B Mahol : On 12/11/18, Paul B Mahol wrote: > On 12/11/18, Carl Eugen Hoyos wrote: >> 2018-12-11 17:18 GMT+01:00, Paul B Mah

Re: [FFmpeg-devel] [PATCH] avcodec: rewrite gif muxing and encoding

2018-12-11 Thread Carl Eugen Hoyos
2018-12-11 17:40 GMT+01:00, Paul B Mahol : > On 12/11/18, Carl Eugen Hoyos wrote: >> 2018-12-11 17:37 GMT+01:00, Paul B Mahol : >>> On 12/11/18, Paul B Mahol wrote: On 12/11/18, Carl Eugen Hoyos wrote: > 2018-12-11 17:18 GMT+01:00, Paul B Mahol : >> On 12/11/18, Carl Eugen Hoyos wr

Re: [FFmpeg-devel] [PATCH] avcodec: rewrite gif muxing and encoding

2018-12-11 Thread Paul B Mahol
On 12/11/18, Carl Eugen Hoyos wrote: > 2018-12-11 17:37 GMT+01:00, Paul B Mahol : >> On 12/11/18, Paul B Mahol wrote: >>> On 12/11/18, Carl Eugen Hoyos wrote: 2018-12-11 17:18 GMT+01:00, Paul B Mahol : > On 12/11/18, Carl Eugen Hoyos wrote: >> 2018-12-11 16:02 GMT+01:00, Paul B Mah

Re: [FFmpeg-devel] [PATCH] avcodec: rewrite gif muxing and encoding

2018-12-11 Thread Carl Eugen Hoyos
2018-12-11 17:37 GMT+01:00, Paul B Mahol : > On 12/11/18, Paul B Mahol wrote: >> On 12/11/18, Carl Eugen Hoyos wrote: >>> 2018-12-11 17:18 GMT+01:00, Paul B Mahol : On 12/11/18, Carl Eugen Hoyos wrote: > 2018-12-11 16:02 GMT+01:00, Paul B Mahol : >> Now "-c copy" works. > >

Re: [FFmpeg-devel] [PATCH] avcodec: rewrite gif muxing and encoding

2018-12-11 Thread Paul B Mahol
On 12/11/18, Paul B Mahol wrote: > On 12/11/18, Carl Eugen Hoyos wrote: >> 2018-12-11 17:18 GMT+01:00, Paul B Mahol : >>> On 12/11/18, Carl Eugen Hoyos wrote: 2018-12-11 16:02 GMT+01:00, Paul B Mahol : > Now "-c copy" works. Please mention ticket #6640. When using th

Re: [FFmpeg-devel] [PATCH] avcodec: rewrite gif muxing and encoding

2018-12-11 Thread Paul B Mahol
On 12/11/18, Carl Eugen Hoyos wrote: > 2018-12-11 17:18 GMT+01:00, Paul B Mahol : >> On 12/11/18, Carl Eugen Hoyos wrote: >>> 2018-12-11 16:02 GMT+01:00, Paul B Mahol : Now "-c copy" works. >>> >>> Please mention ticket #6640. >>> >>> When using the commands there, the output file has a diff

Re: [FFmpeg-devel] [PATCH] avcodec: rewrite gif muxing and encoding

2018-12-11 Thread Carl Eugen Hoyos
2018-12-11 17:18 GMT+01:00, Paul B Mahol : > On 12/11/18, Carl Eugen Hoyos wrote: >> 2018-12-11 16:02 GMT+01:00, Paul B Mahol : >>> Now "-c copy" works. >> >> Please mention ticket #6640. >> >> When using the commands there, the output file has a different >> byte at position 0xbb06 (0x0a -> 0x05)

Re: [FFmpeg-devel] [PATCH] avcodec: rewrite gif muxing and encoding

2018-12-11 Thread Paul B Mahol
On 12/11/18, Carl Eugen Hoyos wrote: > 2018-12-11 16:02 GMT+01:00, Paul B Mahol : >> Now "-c copy" works. > > Please mention ticket #6640. > > When using the commands there, the output file has a different > byte at position 0xbb06 (0x0a -> 0x05), do you know why? Dunno, md5 of decoded output is

Re: [FFmpeg-devel] [PATCH] avcodec: rewrite gif muxing and encoding

2018-12-11 Thread Carl Eugen Hoyos
2018-12-11 16:02 GMT+01:00, Paul B Mahol : > Now "-c copy" works. Please mention ticket #6640. When using the commands there, the output file has a different byte at position 0xbb06 (0x0a -> 0x05), do you know why? Carl Eugen ___ ffmpeg-devel mailing l

Re: [FFmpeg-devel] [PATCH] avcodec: rewrite gif muxing and encoding

2018-12-11 Thread Carl Eugen Hoyos
2018-12-11 15:12 GMT+01:00, Paul B Mahol : > Now "-c copy" works. Please mention ticket #6640. The last frame seems missing, at least with the commands from this ticket. Thank you, Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http:/