Re: [FFmpeg-devel] [PATCH] avcodec: add drop_changed_frames

2019-04-15 Thread Hendrik Leppkes
On Mon, Apr 15, 2019 at 8:17 AM Gyan wrote: > > > > On 15-04-2019 12:17 AM, James Almer wrote: > > On 4/14/2019 3:29 PM, Hendrik Leppkes wrote: > >> On Sun, Apr 14, 2019 at 6:50 PM Gyan wrote: > >>> Implemented this patch > >>> http://www.ffmpeg.org/pipermail/ffmpeg-devel/2019-March/241733.html >

Re: [FFmpeg-devel] [PATCH] avcodec: add drop_changed_frames

2019-04-14 Thread Gyan
On 15-04-2019 12:17 AM, James Almer wrote: On 4/14/2019 3:29 PM, Hendrik Leppkes wrote: On Sun, Apr 14, 2019 at 6:50 PM Gyan wrote: Implemented this patch http://www.ffmpeg.org/pipermail/ffmpeg-devel/2019-March/241733.html in libavcodec as suggested by Michael This sure adds a lot of

Re: [FFmpeg-devel] [PATCH] avcodec: add drop_changed_frames

2019-04-14 Thread James Almer
On 4/14/2019 3:29 PM, Hendrik Leppkes wrote: > On Sun, Apr 14, 2019 at 6:50 PM Gyan wrote: >> >> Implemented this patch >> http://www.ffmpeg.org/pipermail/ffmpeg-devel/2019-March/241733.html >> >> >> in libavcodec as suggested by Michael >> > > This sure adds a lot of additional fields to the m

Re: [FFmpeg-devel] [PATCH] avcodec: add drop_changed_frames

2019-04-14 Thread Hendrik Leppkes
On Sun, Apr 14, 2019 at 6:50 PM Gyan wrote: > > Implemented this patch > http://www.ffmpeg.org/pipermail/ffmpeg-devel/2019-March/241733.html > > > in libavcodec as suggested by Michael > This sure adds a lot of additional fields to the main struct for a rather specialized feature, that I person

Re: [FFmpeg-devel] [PATCH] avcodec: add drop_changed_frames

2019-04-14 Thread Marton Balint
On Sun, 14 Apr 2019, Gyan wrote: On 14-04-2019 10:29 PM, Marton Balint wrote: On Sun, 14 Apr 2019, Gyan wrote: Implemented this patch http://www.ffmpeg.org/pipermail/ffmpeg-devel/2019-March/241733.html  in libavcodec as suggested by Michael Docs should mention that you are not only

Re: [FFmpeg-devel] [PATCH] avcodec: add drop_changed_frames

2019-04-14 Thread Gyan
On 14-04-2019 10:29 PM, Marton Balint wrote: On Sun, 14 Apr 2019, Gyan wrote: Implemented this patch http://www.ffmpeg.org/pipermail/ffmpeg-devel/2019-March/241733.html  in libavcodec as suggested by Michael Docs should mention that you are not only dropping the frames but returning e

Re: [FFmpeg-devel] [PATCH] avcodec: add drop_changed_frames

2019-04-14 Thread Marton Balint
On Sun, 14 Apr 2019, Gyan wrote: Implemented this patch http://www.ffmpeg.org/pipermail/ffmpeg-devel/2019-March/241733.html  in libavcodec as suggested by Michael Docs should mention that you are not only dropping the frames but returning error as well. (I agree that error should be retu