Re: [FFmpeg-devel] [PATCH] avcodec: add ARBC decoder

2019-01-23 Thread Paul B Mahol
On 1/22/19, Michael Niedermayer wrote: > On Tue, Jan 22, 2019 at 10:55:33AM +0100, Paul B Mahol wrote: >> Thanks Kostya for great help in reversing binary. >> >> Signed-off-by: Paul B Mahol >> --- >> libavcodec/Makefile | 1 + >> libavcodec/allcodecs.c | 1 + >> libavcodec/arbc.c

Re: [FFmpeg-devel] [PATCH] avcodec: add ARBC decoder

2019-01-22 Thread Michael Niedermayer
On Tue, Jan 22, 2019 at 10:55:33AM +0100, Paul B Mahol wrote: > Thanks Kostya for great help in reversing binary. > > Signed-off-by: Paul B Mahol > --- > libavcodec/Makefile | 1 + > libavcodec/allcodecs.c | 1 + > libavcodec/arbc.c | 203 >

Re: [FFmpeg-devel] [PATCH] avcodec: add ARBC decoder

2019-01-22 Thread James Almer
On 1/22/2019 11:54 AM, Paul B Mahol wrote: > On 1/22/19, James Almer wrote: >> On 1/22/2019 10:30 AM, Paul B Mahol wrote: >>> On 1/22/19, James Almer wrote: On 1/22/2019 6:55 AM, Paul B Mahol wrote: > Thanks Kostya for great help in reversing binary. > > Signed-off-by: Paul B Mah

Re: [FFmpeg-devel] [PATCH] avcodec: add ARBC decoder

2019-01-22 Thread Peter Ross
On Tue, Jan 22, 2019 at 10:22:29AM -0300, James Almer wrote: > On 1/22/2019 6:55 AM, Paul B Mahol wrote: > > Thanks Kostya for great help in reversing binary. :) > > +static void fill_tile4(AVCodecContext *avctx, uint8_t *color, AVFrame > > *frame) > > +{ > > +ARBCContext *s = avctx->priv_da

Re: [FFmpeg-devel] [PATCH] avcodec: add ARBC decoder

2019-01-22 Thread Paul B Mahol
On 1/22/19, Jean-Baptiste Kempf wrote: > On Tue, 22 Jan 2019, at 10:55, Paul B Mahol wrote: >> Signed-off-by: Paul B Mahol > > Overall, this is more readable that the ones in the past. Really cool. With that terms: "more readable" actually means "less complex" > >> +for (int j = start_y

Re: [FFmpeg-devel] [PATCH] avcodec: add ARBC decoder

2019-01-22 Thread Paul B Mahol
On 1/22/19, James Almer wrote: > On 1/22/2019 10:30 AM, Paul B Mahol wrote: >> On 1/22/19, James Almer wrote: >>> On 1/22/2019 6:55 AM, Paul B Mahol wrote: Thanks Kostya for great help in reversing binary. Signed-off-by: Paul B Mahol --- libavcodec/Makefile | 1 +

Re: [FFmpeg-devel] [PATCH] avcodec: add ARBC decoder

2019-01-22 Thread Jean-Baptiste Kempf
On Tue, 22 Jan 2019, at 10:55, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol Overall, this is more readable that the ones in the past. Really cool. > +for (int j = start_y; j < end_y; j++) { > +for (int k = start_x; k < end_x; k++) { > +if (mask & 0x8000)

Re: [FFmpeg-devel] [PATCH] avcodec: add ARBC decoder

2019-01-22 Thread James Almer
On 1/22/2019 10:30 AM, Paul B Mahol wrote: > On 1/22/19, James Almer wrote: >> On 1/22/2019 6:55 AM, Paul B Mahol wrote: >>> Thanks Kostya for great help in reversing binary. >>> >>> Signed-off-by: Paul B Mahol >>> --- >>> libavcodec/Makefile | 1 + >>> libavcodec/allcodecs.c | 1 + >>>

Re: [FFmpeg-devel] [PATCH] avcodec: add ARBC decoder

2019-01-22 Thread Paul B Mahol
On 1/22/19, James Almer wrote: > On 1/22/2019 6:55 AM, Paul B Mahol wrote: >> Thanks Kostya for great help in reversing binary. >> >> Signed-off-by: Paul B Mahol >> --- >> libavcodec/Makefile | 1 + >> libavcodec/allcodecs.c | 1 + >> libavcodec/arbc.c | 203 ++

Re: [FFmpeg-devel] [PATCH] avcodec: add ARBC decoder

2019-01-22 Thread James Almer
On 1/22/2019 6:55 AM, Paul B Mahol wrote: > Thanks Kostya for great help in reversing binary. > > Signed-off-by: Paul B Mahol > --- > libavcodec/Makefile | 1 + > libavcodec/allcodecs.c | 1 + > libavcodec/arbc.c | 203 > libavcodec/avcodec

Re: [FFmpeg-devel] [PATCH] avcodec: add ARBC decoder

2019-01-22 Thread Moritz Barsnick
On Tue, Jan 22, 2019 at 10:55:33 +0100, Paul B Mahol wrote: > libavcodec/Makefile | 1 + > libavcodec/allcodecs.c | 1 + > libavcodec/arbc.c | 203 > libavcodec/avcodec.h| 1 + > libavcodec/codec_desc.c | 7 ++ > libavformat/riff.c