> Hi
>
[...]
>
> iam not sure this is valid C and not undefined
>
> but either way this patch breaks fate
>
> TESTvc1-ism
> --- ./tests/ref/fate/vc1-ism 2018-11-13 19:52:23.489023763 +0100
> +++ tests/data/fate/vc1-ism 2018-11-14 21:50:11.522992878 +0100
> @@ -2,7 +2,7 @@
> #media_type
Hi
On Wed, Nov 14, 2018 at 10:57:25AM +0100, Jerome Borsboom wrote:
> According to VC-1 spec:
> * Display size defaults to max coded size when not explicitly set in
> sequence header
> * Aspect ratio in the sequence header refers to the Display size elements.
> Therefore, the aspect ratio for the
2018-11-14 17:16 GMT+01:00, Jerome Borsboom :
>>> +av_reduce(&avctx->sample_aspect_ratio.num,
>>> + &avctx->sample_aspect_ratio.den,
>>> + v->disp_horiz_size * v->aspect_ratio.num * h,
>>> + v->disp_vert_size * v->aspect_ratio.den * w,
>>> + 1
>> +av_reduce(&avctx->sample_aspect_ratio.num,
>> + &avctx->sample_aspect_ratio.den,
>> + v->disp_horiz_size * v->aspect_ratio.num * h,
>> + v->disp_vert_size * v->aspect_ratio.den * w,
>> + 1 << 30);
>
>> +ff_set_sar(avctx, avctx->sample
2018-11-14 10:57 GMT+01:00, Jerome Borsboom :
> +av_reduce(&avctx->sample_aspect_ratio.num,
> + &avctx->sample_aspect_ratio.den,
> + v->disp_horiz_size * v->aspect_ratio.num * h,
> + v->disp_vert_size * v->aspect_ratio.den * w,
> + 1 << 30);