Re: [FFmpeg-devel] [PATCH] avcodec/snowdec: Check ld/cbd/crd

2017-09-04 Thread Michael Niedermayer
On Mon, Sep 04, 2017 at 11:58:07AM -0300, James Almer wrote: > On 9/4/2017 6:48 AM, Michael Niedermayer wrote: > > On Mon, Sep 04, 2017 at 12:57:32AM +, Kieran Kunhya wrote: > >> On Mon, 4 Sep 2017 at 00:56 Michael Niedermayer > >> wrote: > >> > >>> We have always printed error messages for th

Re: [FFmpeg-devel] [PATCH] avcodec/snowdec: Check ld/cbd/crd

2017-09-04 Thread James Almer
On 9/4/2017 6:48 AM, Michael Niedermayer wrote: > On Mon, Sep 04, 2017 at 12:57:32AM +, Kieran Kunhya wrote: >> On Mon, 4 Sep 2017 at 00:56 Michael Niedermayer >> wrote: >> >>> We have always printed error messages for the case that an error >>> occured. >>> Its unprofessional to fail decoding

Re: [FFmpeg-devel] [PATCH] avcodec/snowdec: Check ld/cbd/crd

2017-09-04 Thread Carl Eugen Hoyos
Hi! > Am 04.09.2017 um 13:48 schrieb "Ronald S. Bultje" : > > Hi, > > On Mon, Sep 4, 2017 at 5:30 AM, Michael Niedermayer > wrote: > >> But lets just assume for the sake of the argument, that it is useless, >> can you take a look at these please: >> (this is a uncut list of errors from vp9.c)

Re: [FFmpeg-devel] [PATCH] avcodec/snowdec: Check ld/cbd/crd

2017-09-04 Thread Ronald S. Bultje
Hi, On Mon, Sep 4, 2017 at 5:30 AM, Michael Niedermayer wrote: > But lets just assume for the sake of the argument, that it is useless, > can you take a look at these please: > (this is a uncut list of errors from vp9.c) > But mommy, he did it too. I veto your patch. If it makes you feel bett

Re: [FFmpeg-devel] [PATCH] avcodec/snowdec: Check ld/cbd/crd

2017-09-04 Thread Michael Niedermayer
On Mon, Sep 04, 2017 at 12:57:32AM +, Kieran Kunhya wrote: > On Mon, 4 Sep 2017 at 00:56 Michael Niedermayer > wrote: > > > We have always printed error messages for the case that an error > > occured. > > Its unprofessional to fail decoding a file but not provide any > > hint as to why a fai

Re: [FFmpeg-devel] [PATCH] avcodec/snowdec: Check ld/cbd/crd

2017-09-04 Thread Michael Niedermayer
On Sun, Sep 03, 2017 at 09:27:53PM -0400, Ronald S. Bultje wrote: > Hi, > > On Sun, Sep 3, 2017 at 7:54 PM, Michael Niedermayer > wrote: > > > Its unprofessional to fail decoding a file but not provide any > > hint as to why a failure occured. > > > [..] > > > Our code is already quite terse an

Re: [FFmpeg-devel] [PATCH] avcodec/snowdec: Check ld/cbd/crd

2017-09-03 Thread Ronald S. Bultje
Hi, On Sun, Sep 3, 2017 at 7:54 PM, Michael Niedermayer wrote: > Its unprofessional to fail decoding a file but not provide any > hint as to why a failure occured. > [..] > Our code is already quite terse and devoid of comments and > documentation, error messages do not seem a exception here

Re: [FFmpeg-devel] [PATCH] avcodec/snowdec: Check ld/cbd/crd

2017-09-03 Thread Kieran Kunhya
On Mon, 4 Sep 2017 at 00:56 Michael Niedermayer wrote: > We have always printed error messages for the case that an error > occured. > Its unprofessional to fail decoding a file but not provide any > hint as to why a failure occured. > > If we remove all error messages and just print a generic "f

Re: [FFmpeg-devel] [PATCH] avcodec/snowdec: Check ld/cbd/crd

2017-09-03 Thread Michael Niedermayer
On Sun, Sep 03, 2017 at 11:43:54AM -0300, James Almer wrote: > On 9/3/2017 10:49 AM, Ronald S. Bultje wrote: > > Hi, > > > > On Sun, Sep 3, 2017 at 6:23 AM, Michael Niedermayer > > wrote: > > > >> Fixes: Timeout > >> Fixes: 3142/clusterfuzz-testcase-5007853163118592 > >> > >> Found-by: continuou

Re: [FFmpeg-devel] [PATCH] avcodec/snowdec: Check ld/cbd/crd

2017-09-03 Thread James Almer
On 9/3/2017 10:49 AM, Ronald S. Bultje wrote: > Hi, > > On Sun, Sep 3, 2017 at 6:23 AM, Michael Niedermayer > wrote: > >> Fixes: Timeout >> Fixes: 3142/clusterfuzz-testcase-5007853163118592 >> >> Found-by: continuous fuzzing process https://github.com/google/oss- >> fuzz/tree/master/projects/ffm

Re: [FFmpeg-devel] [PATCH] avcodec/snowdec: Check ld/cbd/crd

2017-09-03 Thread Ronald S. Bultje
Hi, On Sun, Sep 3, 2017 at 6:23 AM, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: 3142/clusterfuzz-testcase-5007853163118592 > > Found-by: continuous fuzzing process https://github.com/google/oss- > fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer > --- > libavcodec