Re: [FFmpeg-devel] [PATCH] avcodec/mpegvideo_enc: fix memory leak

2016-09-26 Thread Timo Rothenpieler
> Will push later today, unless someone has a better idea how to address > this issue. > Maybe some way to not use av_frame_copy_props in the first place? applied ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ff

Re: [FFmpeg-devel] [PATCH] avcodec/mpegvideo_enc: fix memory leak

2016-09-26 Thread Timo Rothenpieler
> When the input frames contain side data, it will accumulate endlessly in > the coded frame, as av_frame_copy_props will append any new side data. > --- > libavcodec/mpegvideo_enc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c >

Re: [FFmpeg-devel] [PATCH] avcodec/mpegvideo_enc: fix memory leak

2016-09-25 Thread Nicolas George
Le quartidi 4 vendémiaire, an CCXXV, Carl Eugen Hoyos a écrit : > (Massive) memory consumption. That would be if the consumption was necessary. Regards, -- Nicolas George signature.asc Description: Digital signature ___ ffmpeg-devel mailing list f

Re: [FFmpeg-devel] [PATCH] avcodec/mpegvideo_enc: fix memory leak

2016-09-25 Thread Carl Eugen Hoyos
2016-09-25 16:00 GMT+02:00 Nicolas George : > Le quartidi 4 vendémiaire, an CCXXV, Carl Eugen Hoyos a écrit : >> > And without this, ffmpeg keeps using more and more memory. >> > So while the memory is eventually freed when the encoding is done >> I believe this defines it as not being a leak. > >

Re: [FFmpeg-devel] [PATCH] avcodec/mpegvideo_enc: fix memory leak

2016-09-25 Thread Carl Eugen Hoyos
2016-09-25 15:59 GMT+02:00 Timo Rothenpieler : >>> And without this, ffmpeg keeps using more and more memory. >>> So while the memory is eventually freed when the encoding is done >> >> I believe this defines it as not being a leak. > > What else would it be? (Massive) memory consumption. Carl E

Re: [FFmpeg-devel] [PATCH] avcodec/mpegvideo_enc: fix memory leak

2016-09-25 Thread Nicolas George
Le quartidi 4 vendémiaire, an CCXXV, Carl Eugen Hoyos a écrit : > > And without this, ffmpeg keeps using more and more memory. > > So while the memory is eventually freed when the encoding is done > I believe this defines it as not being a leak. I believe you are wrong. It is not the same kind of

Re: [FFmpeg-devel] [PATCH] avcodec/mpegvideo_enc: fix memory leak

2016-09-25 Thread Timo Rothenpieler
On 9/25/2016 3:55 PM, Carl Eugen Hoyos wrote: > 2016-09-25 15:47 GMT+02:00 Timo Rothenpieler : >> On 9/25/2016 3:44 PM, Carl Eugen Hoyos wrote: >>> 2016-09-25 15:43 GMT+02:00 Timo Rothenpieler : When the input frames contain side data, it will accumulate endlessly in the coded frame, as a

Re: [FFmpeg-devel] [PATCH] avcodec/mpegvideo_enc: fix memory leak

2016-09-25 Thread Carl Eugen Hoyos
2016-09-25 15:47 GMT+02:00 Timo Rothenpieler : > On 9/25/2016 3:44 PM, Carl Eugen Hoyos wrote: >> 2016-09-25 15:43 GMT+02:00 Timo Rothenpieler : >>> When the input frames contain side data, it will accumulate >>> endlessly in the coded frame, as av_frame_copy_props will >>> append any new side data

Re: [FFmpeg-devel] [PATCH] avcodec/mpegvideo_enc: fix memory leak

2016-09-25 Thread Timo Rothenpieler
On 9/25/2016 3:44 PM, Carl Eugen Hoyos wrote: > 2016-09-25 15:43 GMT+02:00 Timo Rothenpieler : >> When the input frames contain side data, it will accumulate endlessly in >> the coded frame, as av_frame_copy_props will append any new side data. > > But there is no leak, no? > Is this related to ti

Re: [FFmpeg-devel] [PATCH] avcodec/mpegvideo_enc: fix memory leak

2016-09-25 Thread Carl Eugen Hoyos
2016-09-25 15:43 GMT+02:00 Timo Rothenpieler : > When the input frames contain side data, it will accumulate endlessly in > the coded frame, as av_frame_copy_props will append any new side data. But there is no leak, no? Is this related to ticket #5799? Carl Eugen